Skip to content

Commit

Permalink
perf ui gtk: Rename functions for consistency
Browse files Browse the repository at this point in the history
We use double underscore characters to distinguish its subsystem and
actual function name.

Signed-off-by: Namhyung Kim <namhyung.kim@lge.com>
Acked-by: Pekka Enberg <penberg@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Pekka Enberg <penberg@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1335761711-31403-4-git-send-email-namhyung.kim@lge.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  • Loading branch information
Namhyung Kim authored and Arnaldo Carvalho de Melo committed May 2, 2012
1 parent 7706f96 commit 28e62b9
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 17 deletions.
2 changes: 1 addition & 1 deletion tools/perf/builtin-report.c
Original file line number Diff line number Diff line change
Expand Up @@ -678,7 +678,7 @@ int cmd_report(int argc, const char **argv, const char *prefix __used)

if (strcmp(report.input_name, "-") != 0) {
if (report.use_gtk)
perf_gtk_setup_browser(true);
perf_gtk__setup_browser(true);
else
setup_browser(true);
} else {
Expand Down
24 changes: 12 additions & 12 deletions tools/perf/ui/gtk/browser.c
Original file line number Diff line number Diff line change
Expand Up @@ -9,23 +9,23 @@

#define MAX_COLUMNS 32

void perf_gtk_setup_browser(bool fallback_to_pager __used)
void perf_gtk__setup_browser(bool fallback_to_pager __used)
{
gtk_init(NULL, NULL);
}

void perf_gtk_exit_browser(bool wait_for_ok __used)
void perf_gtk__exit_browser(bool wait_for_ok __used)
{
gtk_main_quit();
}

static void perf_gtk_signal(int sig)
static void perf_gtk__signal(int sig)
{
psignal(sig, "perf");
gtk_main_quit();
}

static void perf_gtk_resize_window(GtkWidget *window)
static void perf_gtk__resize_window(GtkWidget *window)
{
GdkRectangle rect;
GdkScreen *screen;
Expand All @@ -45,7 +45,7 @@ static void perf_gtk_resize_window(GtkWidget *window)
gtk_window_resize(GTK_WINDOW(window), width, height);
}

static void perf_gtk_show_hists(GtkWidget *window, struct hists *hists)
static void perf_gtk__show_hists(GtkWidget *window, struct hists *hists)
{
GType col_types[MAX_COLUMNS];
GtkCellRenderer *renderer;
Expand Down Expand Up @@ -141,11 +141,11 @@ int perf_evlist__gtk_browse_hists(struct perf_evlist *evlist,
GtkWidget *notebook;
GtkWidget *window;

signal(SIGSEGV, perf_gtk_signal);
signal(SIGFPE, perf_gtk_signal);
signal(SIGINT, perf_gtk_signal);
signal(SIGQUIT, perf_gtk_signal);
signal(SIGTERM, perf_gtk_signal);
signal(SIGSEGV, perf_gtk__signal);
signal(SIGFPE, perf_gtk__signal);
signal(SIGINT, perf_gtk__signal);
signal(SIGQUIT, perf_gtk__signal);
signal(SIGTERM, perf_gtk__signal);

window = gtk_window_new(GTK_WINDOW_TOPLEVEL);

Expand All @@ -167,7 +167,7 @@ int perf_evlist__gtk_browse_hists(struct perf_evlist *evlist,
GTK_POLICY_AUTOMATIC,
GTK_POLICY_AUTOMATIC);

perf_gtk_show_hists(scrolled_window, hists);
perf_gtk__show_hists(scrolled_window, hists);

tab_label = gtk_label_new(evname);

Expand All @@ -178,7 +178,7 @@ int perf_evlist__gtk_browse_hists(struct perf_evlist *evlist,

gtk_widget_show_all(window);

perf_gtk_resize_window(window);
perf_gtk__resize_window(window);

gtk_window_set_position(GTK_WINDOW(window), GTK_WIN_POS_CENTER);

Expand Down
8 changes: 4 additions & 4 deletions tools/perf/util/cache.h
Original file line number Diff line number Diff line change
Expand Up @@ -46,15 +46,15 @@ void exit_browser(bool wait_for_ok);
#endif

#ifdef NO_GTK2_SUPPORT
static inline void perf_gtk_setup_browser(bool fallback_to_pager)
static inline void perf_gtk__setup_browser(bool fallback_to_pager)
{
if (fallback_to_pager)
setup_pager();
}
static inline void perf_gtk_exit_browser(bool wait_for_ok __used) {}
static inline void perf_gtk__exit_browser(bool wait_for_ok __used) {}
#else
void perf_gtk_setup_browser(bool fallback_to_pager);
void perf_gtk_exit_browser(bool wait_for_ok);
void perf_gtk__setup_browser(bool fallback_to_pager);
void perf_gtk__exit_browser(bool wait_for_ok);
#endif

char *alias_lookup(const char *alias);
Expand Down

0 comments on commit 28e62b9

Please sign in to comment.