Skip to content

Commit

Permalink
[PATCH] v4l: 893: rollback recent i2c change to solve tuner detection…
Browse files Browse the repository at this point in the history
… breakage

- Rollback recent i2c change to solve tuner detection breakage

Signed-off-by: Ricardo Cerqueira <v4l@cerqueira.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@brturbo.com.br>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Ricardo Cerqueira authored and Linus Torvalds committed Nov 9, 2005
1 parent d0fcdd7 commit 291d1d7
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 11 deletions.
22 changes: 13 additions & 9 deletions drivers/media/video/bttv-i2c.c
Original file line number Diff line number Diff line change
Expand Up @@ -291,10 +291,12 @@ static struct i2c_adapter bttv_i2c_adap_hw_template = {
static int attach_inform(struct i2c_client *client)
{
struct bttv *btv = i2c_get_adapdata(client->adapter);
int radio_addr=ADDR_UNSET;
int addr=ADDR_UNSET;


if (ADDR_UNSET != bttv_tvcards[btv->c.type].tuner_addr)
addr = bttv_tvcards[btv->c.type].tuner_addr;

if (ADDR_UNSET != bttv_tvcards[btv->c.type].radio_addr)
radio_addr = bttv_tvcards[btv->c.type].radio_addr;

if (bttv_debug)
printk(KERN_DEBUG "bttv%d: %s i2c attach [addr=0x%x,client=%s]\n",
Expand All @@ -305,14 +307,16 @@ static int attach_inform(struct i2c_client *client)

if (btv->tuner_type != UNSET) {
struct tuner_setup tun_setup;
struct tuner *t = i2c_get_clientdata(client);

if (t->type != UNSET && t->mode_mask == T_RADIO) {
tun_setup.type = t->type;
tun_setup.mode_mask = T_RADIO;
tun_setup.addr = radio_addr;
client->driver->command (client, TUNER_SET_TYPE_ADDR, &tun_setup);
if ((addr==ADDR_UNSET) ||
(addr==client->addr)) {

tun_setup.mode_mask = T_ANALOG_TV | T_DIGITAL_TV | T_RADIO;
tun_setup.type = btv->tuner_type;
tun_setup.addr = addr;
bttv_call_i2c_clients(btv, TUNER_SET_TYPE_ADDR, &tun_setup);
}

}

return 0;
Expand Down
4 changes: 2 additions & 2 deletions drivers/media/video/tuner-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -222,9 +222,9 @@ static void set_addr(struct i2c_client *c, struct tuner_setup *tun_setup)
{
struct tuner *t = i2c_get_clientdata(c);

if ((tun_setup->addr == ADDR_UNSET &&
if ( t->type == UNSET && ((tun_setup->addr == ADDR_UNSET &&
(t->mode_mask & tun_setup->mode_mask)) ||
tun_setup->addr == c->addr) {
tun_setup->addr == c->addr)) {
set_type(c, tun_setup->type, tun_setup->mode_mask);
}
}
Expand Down

0 comments on commit 291d1d7

Please sign in to comment.