Skip to content

Commit

Permalink
rtc: remove __raw_* accessors from PL031 RTC
Browse files Browse the repository at this point in the history
This switches __raw_[read|write]l() for plain [read|write]l in the PL031
RTC driver.  The sister driver for PL030 use the simple accessors as most
PrimeCell drivers.

Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Alessandro Zummo <a.zummo@towertech.it>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Linus Walleij authored and Linus Torvalds committed Dec 16, 2009
1 parent 1ce7c83 commit 2934d6a
Showing 1 changed file with 12 additions and 11 deletions.
23 changes: 12 additions & 11 deletions drivers/rtc/rtc-pl031.c
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,10 @@ static int pl031_ioctl(struct device *dev, unsigned int cmd, unsigned long arg)

switch (cmd) {
case RTC_AIE_OFF:
__raw_writel(1, ldata->base + RTC_MIS);
writel(1, ldata->base + RTC_MIS);
return 0;
case RTC_AIE_ON:
__raw_writel(0, ldata->base + RTC_MIS);
writel(0, ldata->base + RTC_MIS);
return 0;
}

Expand All @@ -65,7 +65,7 @@ static int pl031_read_time(struct device *dev, struct rtc_time *tm)
{
struct pl031_local *ldata = dev_get_drvdata(dev);

rtc_time_to_tm(__raw_readl(ldata->base + RTC_DR), tm);
rtc_time_to_tm(readl(ldata->base + RTC_DR), tm);

return 0;
}
Expand All @@ -76,7 +76,7 @@ static int pl031_set_time(struct device *dev, struct rtc_time *tm)
struct pl031_local *ldata = dev_get_drvdata(dev);

rtc_tm_to_time(tm, &time);
__raw_writel(time, ldata->base + RTC_LR);
writel(time, ldata->base + RTC_LR);

return 0;
}
Expand All @@ -85,9 +85,9 @@ static int pl031_read_alarm(struct device *dev, struct rtc_wkalrm *alarm)
{
struct pl031_local *ldata = dev_get_drvdata(dev);

rtc_time_to_tm(__raw_readl(ldata->base + RTC_MR), &alarm->time);
alarm->pending = __raw_readl(ldata->base + RTC_RIS);
alarm->enabled = __raw_readl(ldata->base + RTC_IMSC);
rtc_time_to_tm(readl(ldata->base + RTC_MR), &alarm->time);
alarm->pending = readl(ldata->base + RTC_RIS);
alarm->enabled = readl(ldata->base + RTC_IMSC);

return 0;
}
Expand All @@ -99,8 +99,8 @@ static int pl031_set_alarm(struct device *dev, struct rtc_wkalrm *alarm)

rtc_tm_to_time(&alarm->time, &time);

__raw_writel(time, ldata->base + RTC_MR);
__raw_writel(!alarm->enabled, ldata->base + RTC_MIS);
writel(time, ldata->base + RTC_MR);
writel(!alarm->enabled, ldata->base + RTC_MIS);

return 0;
}
Expand Down Expand Up @@ -180,8 +180,9 @@ static int pl031_probe(struct amba_device *adev, struct amba_id *id)

static struct amba_id pl031_ids[] __initdata = {
{
.id = 0x00041031,
.mask = 0x000fffff, },
.id = 0x00041031,
.mask = 0x000fffff,
},
{0, 0},
};

Expand Down

0 comments on commit 2934d6a

Please sign in to comment.