Skip to content

Commit

Permalink
unregister_blkdev(): do WARN_ON on failure
Browse files Browse the repository at this point in the history
When unregister_blkdev() has failed, something wrong happened.  This patch
adds WARN_ON to notify of such badness.

Cc: Jens Axboe <jens.axboe@oracle.com>
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Akinobu Mita authored and Linus Torvalds committed Jul 17, 2007
1 parent 62239ac commit 294462a
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions block/genhd.c
Original file line number Diff line number Diff line change
Expand Up @@ -120,9 +120,10 @@ int unregister_blkdev(unsigned int major, const char *name)
for (n = &major_names[index]; *n; n = &(*n)->next)
if ((*n)->major == major)
break;
if (!*n || strcmp((*n)->name, name))
if (!*n || strcmp((*n)->name, name)) {
WARN_ON(1);
ret = -EINVAL;
else {
} else {
p = *n;
*n = p->next;
}
Expand Down

0 comments on commit 294462a

Please sign in to comment.