Skip to content

Commit

Permalink
[PATCH] fix synclink_gt diagnostics error reporting
Browse files Browse the repository at this point in the history
Fix diagnostics error reporting that was being overwritten by incorrect use
of return codes from individual diagnostic functions.

Signed-off-by: Paul Fulghum <paulkf@microgate.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Paul Fulghum authored and Linus Torvalds committed Jun 25, 2006
1 parent 04b374d commit 294dad0
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/char/synclink_gt.c
Original file line number Diff line number Diff line change
Expand Up @@ -4702,13 +4702,13 @@ static int loopback_test(struct slgt_info *info)
static int adapter_test(struct slgt_info *info)
{
DBGINFO(("testing %s\n", info->device_name));
if ((info->init_error = register_test(info)) < 0) {
if (register_test(info) < 0) {
printk("register test failure %s addr=%08X\n",
info->device_name, info->phys_reg_addr);
} else if ((info->init_error = irq_test(info)) < 0) {
} else if (irq_test(info) < 0) {
printk("IRQ test failure %s IRQ=%d\n",
info->device_name, info->irq_level);
} else if ((info->init_error = loopback_test(info)) < 0) {
} else if (loopback_test(info) < 0) {
printk("loopback test failure %s\n", info->device_name);
}
return info->init_error;
Expand Down

0 comments on commit 294dad0

Please sign in to comment.