Skip to content

Commit

Permalink
[DCCP] CCID2: Fix jiffie wrap issues
Browse files Browse the repository at this point in the history
Jiffies are now handled correctly (I hope) in CCID2.  If they wrap, no
problem.

Signed-off-by: Andrea Bittau <a.bittau@cs.ucl.ac.uk>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Andrea Bittau authored and David S. Miller committed Sep 22, 2006
1 parent 4a0a50f commit 29651cd
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions net/dccp/ccids/ccid2.c
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
*
* BUGS:
* - sequence number wrapping
* - jiffies wrapping
*/

#include "../ccid.h"
Expand Down Expand Up @@ -71,7 +70,8 @@ static void ccid2_hc_tx_check_sanity(const struct ccid2_hc_tx_sock *hctx)

/* packets are sent sequentially */
BUG_ON(seqp->ccid2s_seq <= prev->ccid2s_seq);
BUG_ON(seqp->ccid2s_sent < prev->ccid2s_sent);
BUG_ON(time_before(seqp->ccid2s_sent,
prev->ccid2s_sent));
BUG_ON(len > ccid2_seq_len);

seqp = prev;
Expand Down Expand Up @@ -418,8 +418,8 @@ static inline void ccid2_new_ack(struct sock *sk,

/* update RTO */
if (hctx->ccid2hctx_srtt == -1 ||
(jiffies - hctx->ccid2hctx_lastrtt) >= hctx->ccid2hctx_srtt) {
unsigned long r = jiffies - seqp->ccid2s_sent;
time_after(jiffies, hctx->ccid2hctx_lastrtt + hctx->ccid2hctx_srtt)) {
unsigned long r = (long)jiffies - (long)seqp->ccid2s_sent;
int s;

/* first measurement */
Expand Down

0 comments on commit 29651cd

Please sign in to comment.