Skip to content

Commit

Permalink
staging: comedi: ni_65xx: use mite_alloc()
Browse files Browse the repository at this point in the history
Allocate `struct mite_device` dynamically instead of searching for
one on the `mite_devices` list constructed by the "mite" module.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Ian Abbott authored and Greg Kroah-Hartman committed Sep 17, 2012
1 parent 6dc7120 commit 2967d0a
Showing 1 changed file with 5 additions and 17 deletions.
22 changes: 5 additions & 17 deletions drivers/staging/comedi/drivers/ni_65xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -629,20 +629,6 @@ static int ni_65xx_intr_insn_config(struct comedi_device *dev,
return 2;
}

/* FIXME: remove this when dynamic MITE allocation implemented. */
static struct mite_struct *ni_65xx_find_mite(struct pci_dev *pcidev)
{
struct mite_struct *mite;

for (mite = mite_devices; mite; mite = mite->next) {
if (mite->used)
continue;
if (mite->pcidev == pcidev)
return mite;
}
return NULL;
}

static const struct ni_65xx_board *
ni_65xx_find_boardinfo(struct pci_dev *pcidev)
{
Expand Down Expand Up @@ -672,9 +658,9 @@ static int __devinit ni_65xx_attach_pci(struct comedi_device *dev,
if (!dev->board_ptr)
return -ENODEV;

private(dev)->mite = ni_65xx_find_mite(pcidev);
private(dev)->mite = mite_alloc(pcidev);
if (!private(dev)->mite)
return -ENODEV;
return -ENOMEM;

ret = mite_setup(private(dev)->mite);
if (ret < 0) {
Expand Down Expand Up @@ -810,8 +796,10 @@ static void ni_65xx_detach(struct comedi_device *dev)
kfree(s->private);
s->private = NULL;
}
if (private(dev)->mite)
if (private(dev)->mite) {
mite_unsetup(private(dev)->mite);
mite_free(private(dev)->mite);
}
}
}

Expand Down

0 comments on commit 2967d0a

Please sign in to comment.