Skip to content

Commit

Permalink
[PATCH] ->nr_sectors and ->hard_nr_sectors are not used for BLOCK_PC …
Browse files Browse the repository at this point in the history
…requests

It's a file system thing, for block requests the only size used in the
io paths is ->data_len as it is in bytes, not sectors.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
  • Loading branch information
Jens Axboe committed Dec 19, 2006
1 parent a52de24 commit 2985259
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
6 changes: 2 additions & 4 deletions block/ll_rw_blk.c
Original file line number Diff line number Diff line change
Expand Up @@ -2350,12 +2350,12 @@ static int __blk_rq_map_user(request_queue_t *q, struct request *rq,
else
bio = bio_copy_user(q, uaddr, len, reading);

if (IS_ERR(bio)) {
if (IS_ERR(bio))
return PTR_ERR(bio);
}

orig_bio = bio;
blk_queue_bounce(q, &bio);

/*
* We link the bounce buffer in and could have to traverse it
* later so we have to get a ref to prevent it from being freed
Expand All @@ -2379,8 +2379,6 @@ static int __blk_rq_map_user(request_queue_t *q, struct request *rq,
rq->biotail->bi_next = bio;
rq->biotail = bio;

rq->nr_sectors += bio_sectors(bio);
rq->hard_nr_sectors = rq->nr_sectors;
rq->data_len += bio->bi_size;
}
spin_unlock_irq(q->queue_lock);
Expand Down
2 changes: 0 additions & 2 deletions drivers/scsi/scsi_lib.c
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,6 @@ static int scsi_merge_bio(struct request *rq, struct bio *bio)
else {
rq->biotail->bi_next = bio;
rq->biotail = bio;
rq->hard_nr_sectors += bio_sectors(bio);
rq->nr_sectors = rq->hard_nr_sectors;
}

return 0;
Expand Down

0 comments on commit 2985259

Please sign in to comment.