Skip to content

Commit

Permalink
[PATCH] libata: cosmetic changes in ata_bus_softreset()
Browse files Browse the repository at this point in the history
ata_bus_softreset() should return AC_ERR_* on failure not arbitrary
positive number.  While at it, reformat comment above it.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Acked-by: Alan Cox <alan@redhat.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
  • Loading branch information
Tejun Heo authored and Jeff Garzik committed Mar 25, 2006
1 parent aec5c3c commit 298a41c
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions drivers/scsi/libata-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -2008,13 +2008,12 @@ static unsigned int ata_bus_softreset(struct ata_port *ap,
*/
msleep(150);


/* Before we perform post reset processing we want to see if
the bus shows 0xFF because the odd clown forgets the D7 pulldown
resistor */

* the bus shows 0xFF because the odd clown forgets the D7
* pulldown resistor.
*/
if (ata_check_status(ap) == 0xFF)
return 1; /* Positive is failure for some reason */
return AC_ERR_OTHER;

ata_bus_post_reset(ap, devmask);

Expand Down

0 comments on commit 298a41c

Please sign in to comment.