Skip to content

Commit

Permalink
icmp: Call skb_checksum_simple_validate
Browse files Browse the repository at this point in the history
Use skb_checksum_simple_validate to verify checksum.

Signed-off-by: Tom Herbert <therbert@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Tom Herbert authored and David S. Miller committed May 9, 2014
1 parent de08dc1 commit 29a96e1
Showing 1 changed file with 2 additions and 10 deletions.
12 changes: 2 additions & 10 deletions net/ipv4/icmp.c
Original file line number Diff line number Diff line change
Expand Up @@ -908,16 +908,8 @@ int icmp_rcv(struct sk_buff *skb)

ICMP_INC_STATS_BH(net, ICMP_MIB_INMSGS);

switch (skb->ip_summed) {
case CHECKSUM_COMPLETE:
if (!csum_fold(skb->csum))
break;
/* fall through */
case CHECKSUM_NONE:
skb->csum = 0;
if (__skb_checksum_complete(skb))
goto csum_error;
}
if (skb_checksum_simple_validate(skb))
goto csum_error;

if (!pskb_pull(skb, sizeof(*icmph)))
goto error;
Expand Down

0 comments on commit 29a96e1

Please sign in to comment.