Skip to content

Commit

Permalink
x86: add is_f00f_bug helper to fault_32|64.c
Browse files Browse the repository at this point in the history
Further towards unifying these files, add another helper
in same spirit as is_errata93.

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
  • Loading branch information
Harvey Harrison authored and Ingo Molnar committed Jan 30, 2008
1 parent 9af993a commit 29caf2f
Show file tree
Hide file tree
Showing 2 changed files with 46 additions and 17 deletions.
39 changes: 22 additions & 17 deletions arch/x86/mm/fault_32.c
Original file line number Diff line number Diff line change
Expand Up @@ -211,8 +211,6 @@ void dump_pagetable(unsigned long address)
printk("\n");
}

void do_invalid_op(struct pt_regs *, unsigned long);

static inline pmd_t *vmalloc_sync_one(pgd_t *pgd, unsigned long address)
{
unsigned index = pgd_index(address);
Expand Down Expand Up @@ -288,6 +286,26 @@ static int is_errata93(struct pt_regs *regs, unsigned long address)
return 0;
}

void do_invalid_op(struct pt_regs *, unsigned long);

static int is_f00f_bug(struct pt_regs *regs, unsigned long address)
{
#ifdef CONFIG_X86_F00F_BUG
unsigned long nr;
/*
* Pentium F0 0F C7 C8 bug workaround.
*/
if (boot_cpu_data.f00f_bug) {
nr = (address - idt_descr.address) >> 3;

if (nr == 6) {
do_invalid_op(regs, 0);
return 1;
}
}
#endif
return 0;
}

/*
* Handle a fault on the vmalloc or module mapping area
Expand Down Expand Up @@ -570,21 +588,8 @@ void __kprobes do_page_fault(struct pt_regs *regs, unsigned long error_code)
return;
}

#ifdef CONFIG_X86_F00F_BUG
/*
* Pentium F0 0F C7 C8 bug workaround.
*/
if (boot_cpu_data.f00f_bug) {
unsigned long nr;

nr = (address - idt_descr.address) >> 3;

if (nr == 6) {
do_invalid_op(regs, 0);
return;
}
}
#endif
if (is_f00f_bug(regs, address))
return;

no_context:
/* Are we prepared to handle this kernel fault? */
Expand Down
24 changes: 24 additions & 0 deletions arch/x86/mm/fault_64.c
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,27 @@ static int is_errata93(struct pt_regs *regs, unsigned long address)
return 0;
}

void do_invalid_op(struct pt_regs *, unsigned long);

static int is_f00f_bug(struct pt_regs *regs, unsigned long address)
{
#ifdef CONFIG_X86_F00F_BUG
unsigned long nr;
/*
* Pentium F0 0F C7 C8 bug workaround.
*/
if (boot_cpu_data.f00f_bug) {
nr = (address - idt_descr.address) >> 3;

if (nr == 6) {
do_invalid_op(regs, 0);
return 1;
}
}
#endif
return 0;
}

static noinline void pgtable_bad(unsigned long address, struct pt_regs *regs,
unsigned long error_code)
{
Expand Down Expand Up @@ -581,6 +602,9 @@ asmlinkage void __kprobes do_page_fault(struct pt_regs *regs,
return;
}

if (is_f00f_bug(regs, address))
return;

no_context:
/* Are we prepared to handle this kernel fault? */
if (fixup_exception(regs))
Expand Down

0 comments on commit 29caf2f

Please sign in to comment.