Skip to content

Commit

Permalink
TTY: ircomm, use close times from tty_port
Browse files Browse the repository at this point in the history
Switch to tty_port->close_delay and closing_wait.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Samuel Ortiz <samuel@sortiz.org>
Cc: netdev@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Jiri Slaby authored and Greg Kroah-Hartman committed Jun 12, 2012
1 parent a3cc9fc commit 2a0213c
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 11 deletions.
3 changes: 0 additions & 3 deletions include/net/irda/ircomm_tty.h
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,6 @@ struct ircomm_tty_cb {
struct timer_list watchdog_timer;
struct work_struct tqueue;

unsigned short close_delay;
unsigned short closing_wait; /* time to wait before closing */

int open_count;
int blocked_open; /* # of blocked opens */

Expand Down
10 changes: 4 additions & 6 deletions net/irda/ircomm/ircomm_tty.c
Original file line number Diff line number Diff line change
Expand Up @@ -389,8 +389,6 @@ static int ircomm_tty_open(struct tty_struct *tty, struct file *filp)
INIT_WORK(&self->tqueue, ircomm_tty_do_softint);
self->max_header_size = IRCOMM_TTY_HDR_UNINITIALISED;
self->max_data_size = IRCOMM_TTY_DATA_UNINITIALISED;
self->close_delay = 5*HZ/10;
self->closing_wait = 30*HZ;

/* Init some important stuff */
init_timer(&self->watchdog_timer);
Expand Down Expand Up @@ -546,8 +544,8 @@ static void ircomm_tty_close(struct tty_struct *tty, struct file *filp)
* the line discipline to only process XON/XOFF characters.
*/
tty->closing = 1;
if (self->closing_wait != ASYNC_CLOSING_WAIT_NONE)
tty_wait_until_sent_from_close(tty, self->closing_wait);
if (self->port.closing_wait != ASYNC_CLOSING_WAIT_NONE)
tty_wait_until_sent_from_close(tty, self->port.closing_wait);

ircomm_tty_shutdown(self);

Expand All @@ -558,8 +556,8 @@ static void ircomm_tty_close(struct tty_struct *tty, struct file *filp)
self->tty = NULL;

if (self->blocked_open) {
if (self->close_delay)
schedule_timeout_interruptible(self->close_delay);
if (self->port.close_delay)
schedule_timeout_interruptible(self->port.close_delay);
wake_up_interruptible(&self->port.open_wait);
}

Expand Down
4 changes: 2 additions & 2 deletions net/irda/ircomm/ircomm_tty_ioctl.c
Original file line number Diff line number Diff line change
Expand Up @@ -272,8 +272,8 @@ static int ircomm_tty_get_serial_info(struct ircomm_tty_cb *self,
info.line = self->line;
info.flags = self->flags;
info.baud_base = self->settings.data_rate;
info.close_delay = self->close_delay;
info.closing_wait = self->closing_wait;
info.close_delay = self->port.close_delay;
info.closing_wait = self->port.closing_wait;

/* For compatibility */
info.type = PORT_16550A;
Expand Down

0 comments on commit 2a0213c

Please sign in to comment.