Skip to content

Commit

Permalink
Input: inport, logibm - use KERN_INFO when reporting missing mouse
Browse files Browse the repository at this point in the history
Many mouse drivers are often compiled (e.g. in Linux distributions) into the
kernel at the same time just to make sure that at least one driver will suceed
in find it's mouse device. Nevertheless, only the inport and logitech busmouse
mouse drivers report with KERN_ERR log level if the mouse wasn't found. They
should use KERN_INFO instead, because it's not an error if the mouse isn't
attached at all.

Signed-off-by: Helge Deller <deller@gmx.de>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
  • Loading branch information
Helge Deller authored and Dmitry Torokhov committed Nov 2, 2007
1 parent 2a3e480 commit 2a0f9c4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion drivers/input/mouse/inport.c
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ static int __init inport_init(void)
b = inb(INPORT_SIGNATURE_PORT);
c = inb(INPORT_SIGNATURE_PORT);
if (a == b || a != c) {
printk(KERN_ERR "inport.c: Didn't find InPort mouse at %#x\n", INPORT_BASE);
printk(KERN_INFO "inport.c: Didn't find InPort mouse at %#x\n", INPORT_BASE);
err = -ENODEV;
goto err_release_region;
}
Expand Down
2 changes: 1 addition & 1 deletion drivers/input/mouse/logibm.c
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ static int __init logibm_init(void)
udelay(100);

if (inb(LOGIBM_SIGNATURE_PORT) != LOGIBM_SIGNATURE_BYTE) {
printk(KERN_ERR "logibm.c: Didn't find Logitech busmouse at %#x\n", LOGIBM_BASE);
printk(KERN_INFO "logibm.c: Didn't find Logitech busmouse at %#x\n", LOGIBM_BASE);
err = -ENODEV;
goto err_release_region;
}
Expand Down

0 comments on commit 2a0f9c4

Please sign in to comment.