Skip to content

Commit

Permalink
dm: optimize reorder structure
Browse files Browse the repository at this point in the history
This reorder actually improves performance by 20% (from 39.1s to 32.8s)
on x86-64 quad core Opteron.

I have no explanation for this, possibly it makes some other entries are
better cache-aligned.

Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>
  • Loading branch information
Mikulas Patocka authored and Alasdair G Kergon committed Jul 10, 2013
1 parent 83d5e5b commit 2a7faeb
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions drivers/md/dm.c
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,13 @@ struct mapped_device {
atomic_t holders;
atomic_t open_count;

/*
* The current mapping.
* Use dm_get_live_table{_fast} or take suspend_lock for
* dereference.
*/
struct dm_table *map;

unsigned long flags;

struct request_queue *queue;
Expand Down Expand Up @@ -161,13 +168,6 @@ struct mapped_device {
*/
struct workqueue_struct *wq;

/*
* The current mapping.
* Use dm_get_live_table{_fast} or take suspend_lock for
* dereference.
*/
struct dm_table *map;

/*
* io objects are allocated from here.
*/
Expand Down

0 comments on commit 2a7faeb

Please sign in to comment.