Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 80876
b: refs/heads/master
c: 1f9ffc0
h: refs/heads/master
v: v3
  • Loading branch information
Greg Kroah-Hartman committed Jan 27, 2008
1 parent ce7b746 commit 2a9257e
Show file tree
Hide file tree
Showing 3 changed files with 33 additions and 13 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 123ca9575b1f5342c05a4b84d6af8ba7587c2981
refs/heads/master: 1f9ffc049d7a88c8489b883b6fc0a25185062002
41 changes: 29 additions & 12 deletions trunk/drivers/base/bus.c
Original file line number Diff line number Diff line change
Expand Up @@ -163,23 +163,14 @@ static struct kset *bus_kset;

#ifdef CONFIG_HOTPLUG
/* Manually detach a device from its associated driver. */
static int driver_helper(struct device *dev, void *data)
{
const char *name = data;

if (strcmp(name, dev->bus_id) == 0)
return 1;
return 0;
}

static ssize_t driver_unbind(struct device_driver *drv,
const char *buf, size_t count)
{
struct bus_type *bus = bus_get(drv->bus);
struct device *dev;
int err = -ENODEV;

dev = bus_find_device(bus, NULL, (void *)buf, driver_helper);
dev = bus_find_device_by_name(bus, NULL, buf);
if (dev && dev->driver == drv) {
if (dev->parent) /* Needed for USB */
down(&dev->parent->sem);
Expand All @@ -206,7 +197,7 @@ static ssize_t driver_bind(struct device_driver *drv,
struct device *dev;
int err = -ENODEV;

dev = bus_find_device(bus, NULL, (void *)buf, driver_helper);
dev = bus_find_device_by_name(bus, NULL, buf);
if (dev && dev->driver == NULL) {
if (dev->parent) /* Needed for USB */
down(&dev->parent->sem);
Expand Down Expand Up @@ -250,7 +241,7 @@ static ssize_t store_drivers_probe(struct bus_type *bus,
{
struct device *dev;

dev = bus_find_device(bus, NULL, (void *)buf, driver_helper);
dev = bus_find_device_by_name(bus, NULL, buf);
if (!dev)
return -ENODEV;
if (bus_rescan_devices_helper(dev, NULL) != 0)
Expand Down Expand Up @@ -338,6 +329,32 @@ struct device *bus_find_device(struct bus_type *bus,
}
EXPORT_SYMBOL_GPL(bus_find_device);

static int match_name(struct device *dev, void *data)
{
const char *name = data;

if (strcmp(name, dev->bus_id) == 0)
return 1;
return 0;
}

/**
* bus_find_device_by_name - device iterator for locating a particular device of a specific name
* @bus: bus type
* @start: Device to begin with
* @name: name of the device to match
*
* This is similar to the bus_find_device() function above, but it handles
* searching by a name automatically, no need to write another strcmp matching
* function.
*/
struct device *bus_find_device_by_name(struct bus_type *bus,
struct device *start, const char *name)
{
return bus_find_device(bus, start, (void *)name, match_name);
}
EXPORT_SYMBOL_GPL(bus_find_device_by_name);

static struct device_driver *next_driver(struct klist_iter *i)
{
struct klist_node *n = klist_next(i);
Expand Down
3 changes: 3 additions & 0 deletions trunk/include/linux/device.h
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,9 @@ int bus_for_each_dev(struct bus_type *bus, struct device *start, void *data,
struct device *bus_find_device(struct bus_type *bus, struct device *start,
void *data,
int (*match)(struct device *dev, void *data));
struct device *bus_find_device_by_name(struct bus_type *bus,
struct device *start,
const char *name);

int __must_check bus_for_each_drv(struct bus_type *bus,
struct device_driver *start, void *data,
Expand Down

0 comments on commit 2a9257e

Please sign in to comment.