Skip to content

Commit

Permalink
[DECNET]: cleanups
Browse files Browse the repository at this point in the history
- make the following needlessly global functions static:
  - dn_fib.c: dn_fib_sync_down()
  - dn_fib.c: dn_fib_sync_up()
  - dn_rules.c: dn_fib_rule_action()
- remove the following unneeded prototype:
  - dn_fib.c: dn_cache_dump()

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Adrian Bunk authored and David S. Miller committed Sep 22, 2006
1 parent 50da859 commit 2aa7f36
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 9 deletions.
3 changes: 0 additions & 3 deletions include/net/dn_fib.h
Original file line number Diff line number Diff line change
Expand Up @@ -131,9 +131,6 @@ extern __le16 dn_fib_get_attr16(struct rtattr *attr, int attrlen, int type);
extern void dn_fib_flush(void);
extern void dn_fib_select_multipath(const struct flowi *fl,
struct dn_fib_res *res);
extern int dn_fib_sync_down(__le16 local, struct net_device *dev,
int force);
extern int dn_fib_sync_up(struct net_device *dev);

/*
* dn_tables.c
Expand Down
9 changes: 5 additions & 4 deletions net/decnet/dn_fib.c
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,6 @@

#define endfor_nexthops(fi) }

extern int dn_cache_dump(struct sk_buff *skb, struct netlink_callback *cb);

static DEFINE_SPINLOCK(dn_fib_multipath_lock);
static struct dn_fib_info *dn_fib_info_list;
static DEFINE_SPINLOCK(dn_fib_info_lock);
Expand All @@ -80,6 +78,9 @@ static struct
[RTN_XRESOLVE] = { .error = -EINVAL, .scope = RT_SCOPE_NOWHERE },
};

static int dn_fib_sync_down(__le16 local, struct net_device *dev, int force);
static int dn_fib_sync_up(struct net_device *dev);

void dn_fib_free_info(struct dn_fib_info *fi)
{
if (fi->fib_dead == 0) {
Expand Down Expand Up @@ -651,7 +652,7 @@ static int dn_fib_dnaddr_event(struct notifier_block *this, unsigned long event,
return NOTIFY_DONE;
}

int dn_fib_sync_down(__le16 local, struct net_device *dev, int force)
static int dn_fib_sync_down(__le16 local, struct net_device *dev, int force)
{
int ret = 0;
int scope = RT_SCOPE_NOWHERE;
Expand Down Expand Up @@ -695,7 +696,7 @@ int dn_fib_sync_down(__le16 local, struct net_device *dev, int force)
}


int dn_fib_sync_up(struct net_device *dev)
static int dn_fib_sync_up(struct net_device *dev)
{
int ret = 0;

Expand Down
4 changes: 2 additions & 2 deletions net/decnet/dn_rules.c
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@ int dn_fib_lookup(struct flowi *flp, struct dn_fib_res *res)
return err;
}

int dn_fib_rule_action(struct fib_rule *rule, struct flowi *flp, int flags,
struct fib_lookup_arg *arg)
static int dn_fib_rule_action(struct fib_rule *rule, struct flowi *flp,
int flags, struct fib_lookup_arg *arg)
{
int err = -EAGAIN;
struct dn_fib_table *tbl;
Expand Down

0 comments on commit 2aa7f36

Please sign in to comment.