Skip to content

Commit

Permalink
[PATCH] x86_64: Always pass full number of nodes to NUMA hash computa…
Browse files Browse the repository at this point in the history
…tion

Previously the numa hash code would be confused by holes in the node space
and stop early. This is the first part of the fix for the non boot issue
with empty nodes on Opterons.

Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Andi Kleen authored and Linus Torvalds committed Feb 17, 2006
1 parent fdb9df9 commit 2aed711
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion arch/x86_64/mm/k8topology.c
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ int __init k8_scan_nodes(unsigned long start, unsigned long end)
if (!found)
return -1;

memnode_shift = compute_hash_shift(nodes, numnodes);
memnode_shift = compute_hash_shift(nodes, 8);
if (memnode_shift < 0) {
printk(KERN_ERR "No NUMA node hash function found. Contact maintainer\n");
return -1;
Expand Down
2 changes: 1 addition & 1 deletion arch/x86_64/mm/srat.c
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ int __init acpi_scan_nodes(unsigned long start, unsigned long end)
return -1;
}

memnode_shift = compute_hash_shift(nodes, nodes_weight(nodes_parsed));
memnode_shift = compute_hash_shift(nodes, MAX_NUMNODES);
if (memnode_shift < 0) {
printk(KERN_ERR
"SRAT: No NUMA node hash function found. Contact maintainer\n");
Expand Down

0 comments on commit 2aed711

Please sign in to comment.