Skip to content

Commit

Permalink
target: Refer to u32 luns as unpacked_lun
Browse files Browse the repository at this point in the history
It's clearer to refer to pointers to the struct se_lun as "lun" and the
actual number itself as "unpacked_lun".

Signed-off-by: Andy Grover <agrover@redhat.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
  • Loading branch information
Andy Grover authored and Nicholas Bellinger committed Dec 16, 2013
1 parent ab6dae8 commit 2af7973
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions drivers/target/target_core_device.c
Original file line number Diff line number Diff line change
Expand Up @@ -1112,23 +1112,23 @@ int se_dev_set_block_size(struct se_device *dev, u32 block_size)
struct se_lun *core_dev_add_lun(
struct se_portal_group *tpg,
struct se_device *dev,
u32 lun)
u32 unpacked_lun)
{
struct se_lun *lun_p;
struct se_lun *lun;
int rc;

lun_p = core_tpg_pre_addlun(tpg, lun);
if (IS_ERR(lun_p))
return lun_p;
lun = core_tpg_pre_addlun(tpg, unpacked_lun);
if (IS_ERR(lun))
return lun;

rc = core_tpg_post_addlun(tpg, lun_p,
rc = core_tpg_post_addlun(tpg, lun,
TRANSPORT_LUNFLAGS_READ_WRITE, dev);
if (rc < 0)
return ERR_PTR(rc);

pr_debug("%s_TPG[%u]_LUN[%u] - Activated %s Logical Unit from"
" CORE HBA: %u\n", tpg->se_tpg_tfo->get_fabric_name(),
tpg->se_tpg_tfo->tpg_get_tag(tpg), lun_p->unpacked_lun,
tpg->se_tpg_tfo->tpg_get_tag(tpg), lun->unpacked_lun,
tpg->se_tpg_tfo->get_fabric_name(), dev->se_hba->hba_id);
/*
* Update LUN maps for dynamically added initiators when
Expand All @@ -1149,7 +1149,7 @@ struct se_lun *core_dev_add_lun(
spin_unlock_irq(&tpg->acl_node_lock);
}

return lun_p;
return lun;
}

/* core_dev_del_lun():
Expand Down

0 comments on commit 2af7973

Please sign in to comment.