Skip to content

Commit

Permalink
serial: ifx6x60: probe routine needs to call spi_setup
Browse files Browse the repository at this point in the history
The probe routine should call spi_setup() to configure
the SPI bus so it can properly communicate with the device.
E.g. the device operates in SPI mode 1.

Called spi_setup to configure SPI mode, max_speed_hz, and bpw

Signed-off-by: Russ Gorby <russ.gorby@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Russ Gorby authored and Greg Kroah-Hartman committed Feb 17, 2011
1 parent 1b79b44 commit 2aff8d9
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions drivers/tty/serial/ifx6x60.c
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@
#define IFX_SPI_MORE_MASK 0x10
#define IFX_SPI_MORE_BIT 12 /* bit position in u16 */
#define IFX_SPI_CTS_BIT 13 /* bit position in u16 */
#define IFX_SPI_MODE SPI_MODE_1
#define IFX_SPI_TTY_ID 0
#define IFX_SPI_TIMEOUT_SEC 2
#define IFX_SPI_HEADER_0 (-1)
Expand Down Expand Up @@ -992,7 +993,15 @@ static int ifx_spi_spi_probe(struct spi_device *spi)
ifx_dev->modem = pl_data->modem_type;
ifx_dev->use_dma = pl_data->use_dma;
ifx_dev->max_hz = pl_data->max_hz;
/* initialize spi mode, etc */
spi->max_speed_hz = ifx_dev->max_hz;
spi->mode = IFX_SPI_MODE | (SPI_LOOP & spi->mode);
spi->bits_per_word = spi_bpw;
ret = spi_setup(spi);
if (ret) {
dev_err(&spi->dev, "SPI setup wasn't successful %d", ret);
return -ENODEV;
}

/* ensure SPI protocol flags are initialized to enable transfer */
ifx_dev->spi_more = 0;
Expand Down

0 comments on commit 2aff8d9

Please sign in to comment.