Skip to content

Commit

Permalink
signals: do_signal_stop: kill the SIGNAL_UNKILLABLE check
Browse files Browse the repository at this point in the history
fae5fa4 changed do_signal_stop() to check
SIGNAL_UNKILLABLE, this wasn't needed.  If signal_group_exit() == F, the
signal sent to SIGNAL_UNKILLABLE task must be already filtered out by the
caller, get_signal_to_deliver().  And if signal_group_exit() == T we are
not going to stop.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Acked-by: Roland McGrath <roland@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Oleg Nesterov authored and Linus Torvalds committed Jul 25, 2008
1 parent 92413d7 commit 2b201a9
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions kernel/signal.c
Original file line number Diff line number Diff line change
Expand Up @@ -1649,8 +1649,7 @@ static int do_signal_stop(int signr)
} else {
struct task_struct *t;

if (unlikely((sig->flags & (SIGNAL_STOP_DEQUEUED | SIGNAL_UNKILLABLE))
!= SIGNAL_STOP_DEQUEUED) ||
if (!likely(sig->flags & SIGNAL_STOP_DEQUEUED) ||
unlikely(signal_group_exit(sig)))
return 0;
/*
Expand Down

0 comments on commit 2b201a9

Please sign in to comment.