Skip to content

Commit

Permalink
serial: mxs-auart: fix tx_empty against shift register
Browse files Browse the repository at this point in the history
tx_empty() should test whether both the transmitter fifo and shifter
for the port is empty, ie. the whole last char was transmitted.
The shift register is empty if AUART_STAT_BUSY is cleared.
The patch fixes the function against the shift register.

According to i.MX23 and i.MX28 Reference Manual:
AUART_STAT_TXFE:
 TX FIFO or transmit holding register is empty.

AUART_STAT_BUSY:
 AUART still transmits bits.
 The BUSY signal goes HIGH as soon as the data is written to the
 transmit FIFO (that is, the FIFO is non-empty) and remains asserted
 HIGH while data is being transmitted.
 BUSY is negated only when the transmit FIFO is empty, and the last
 character has been transmitted from the shift register, including
 the stop bits.

Signed-off-by: Janusz Uzycki <j.uzycki@elproma.com.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Janusz Uzycki authored and Greg Kroah-Hartman committed Nov 26, 2014
1 parent 08f937f commit 2b310ec
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions drivers/tty/serial/mxs-auart.c
Original file line number Diff line number Diff line change
Expand Up @@ -913,10 +913,11 @@ static void mxs_auart_shutdown(struct uart_port *u)

static unsigned int mxs_auart_tx_empty(struct uart_port *u)
{
if (readl(u->membase + AUART_STAT) & AUART_STAT_TXFE)
if ((readl(u->membase + AUART_STAT) &
(AUART_STAT_TXFE | AUART_STAT_BUSY)) == AUART_STAT_TXFE)
return TIOCSER_TEMT;
else
return 0;

return 0;
}

static void mxs_auart_start_tx(struct uart_port *u)
Expand Down

0 comments on commit 2b310ec

Please sign in to comment.