Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 48621
b: refs/heads/master
c: 29dbb3f
h: refs/heads/master
i:
  48619: 05a3227
v: v3
  • Loading branch information
NeilBrown authored and Linus Torvalds committed Feb 16, 2007
1 parent 74bd290 commit 2b35b18
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 14 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 3160a711ef754758e7f85ae371cf900252c1a392
refs/heads/master: 29dbb3fc8020f025bc38b262ec494e19fd3eac02
32 changes: 19 additions & 13 deletions trunk/mm/filemap.c
Original file line number Diff line number Diff line change
Expand Up @@ -2079,21 +2079,27 @@ generic_file_buffered_write(struct kiocb *iocb, const struct iovec *iov,
/* Limit the size of the copy to the caller's write size */
bytes = min(bytes, count);

/*
* Limit the size of the copy to that of the current segment,
* because fault_in_pages_readable() doesn't know how to walk
* segments.
/* We only need to worry about prefaulting when writes are from
* user-space. NFSd uses vfs_writev with several non-aligned
* segments in the vector, and limiting to one segment a time is
* a noticeable performance for re-write
*/
bytes = min(bytes, cur_iov->iov_len - iov_base);

/*
* Bring in the user page that we will copy from _first_.
* Otherwise there's a nasty deadlock on copying from the
* same page as we're writing to, without it being marked
* up-to-date.
*/
fault_in_pages_readable(buf, bytes);
if (!segment_eq(get_fs(), KERNEL_DS)) {
/*
* Limit the size of the copy to that of the current
* segment, because fault_in_pages_readable() doesn't
* know how to walk segments.
*/
bytes = min(bytes, cur_iov->iov_len - iov_base);

/*
* Bring in the user page that we will copy from
* _first_. Otherwise there's a nasty deadlock on
* copying from the same page as we're writing to,
* without it being marked up-to-date.
*/
fault_in_pages_readable(buf, bytes);
}
page = __grab_cache_page(mapping,index,&cached_page,&lru_pvec);
if (!page) {
status = -ENOMEM;
Expand Down

0 comments on commit 2b35b18

Please sign in to comment.