Skip to content

Commit

Permalink
mfd: Allow to specify max77686 interrupt through DT or platform file …
Browse files Browse the repository at this point in the history
…also

Presently driver expects irq_gpio pin in platform data and maps it to irq
itself. But we can also directly specify the interrupt in DT or platform file.

Signed-off-by: Yadwinder Singh Brar <yadi.brar@samsung.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
  • Loading branch information
Yadwinder Singh Brar authored and Samuel Ortiz committed Jul 9, 2012
1 parent 9bdf9b4 commit 2b40459
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 13 deletions.
33 changes: 20 additions & 13 deletions drivers/mfd/max77686-irq.c
Original file line number Diff line number Diff line change
Expand Up @@ -252,21 +252,28 @@ int max77686_irq_init(struct max77686_dev *max77686)

mutex_init(&max77686->irqlock);

max77686->irq = gpio_to_irq(max77686->irq_gpio);

if (debug_mask & MAX77686_DEBUG_IRQ_INT) {
ret = gpio_request(max77686->irq_gpio, "pmic_irq");
if (ret < 0) {
dev_err(max77686->dev,
"Failed to request gpio %d with ret: %d\n",
max77686->irq_gpio, ret);
return IRQ_NONE;
if (max77686->irq_gpio && !max77686->irq) {
max77686->irq = gpio_to_irq(max77686->irq_gpio);

if (debug_mask & MAX77686_DEBUG_IRQ_INT) {
ret = gpio_request(max77686->irq_gpio, "pmic_irq");
if (ret < 0) {
dev_err(max77686->dev,
"Failed to request gpio %d with ret:"
"%d\n", max77686->irq_gpio, ret);
return IRQ_NONE;
}

gpio_direction_input(max77686->irq_gpio);
val = gpio_get_value(max77686->irq_gpio);
gpio_free(max77686->irq_gpio);
pr_info("%s: gpio_irq=%x\n", __func__, val);
}
}

gpio_direction_input(max77686->irq_gpio);
val = gpio_get_value(max77686->irq_gpio);
gpio_free(max77686->irq_gpio);
pr_info("%s: gpio_irq=%x\n", __func__, val);
if (!max77686->irq) {
dev_err(max77686->dev, "irq is not specified\n");
return -ENODEV;
}

/* Mask individual interrupt sources */
Expand Down
1 change: 1 addition & 0 deletions drivers/mfd/max77686.c
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ static int max77686_i2c_probe(struct i2c_client *i2c,

max77686->wakeup = pdata->wakeup;
max77686->irq_gpio = pdata->irq_gpio;
max77686->irq = i2c->irq;

if (regmap_read(max77686->regmap,
MAX77686_REG_DEVICE_ID, &data) < 0) {
Expand Down

0 comments on commit 2b40459

Please sign in to comment.