Skip to content

Commit

Permalink
perf stat: Adjust stall cycles warning percentages
Browse files Browse the repository at this point in the history
Adjust to color thresholds to better match the percentages seen in
real workloads. Both are now a bit more sensitive.

Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Link: http://lkml.kernel.org/n/tip-7y40wib8n004io7hjpn1dsrm@git.kernel.org
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Ingo Molnar committed Apr 29, 2011
1 parent d3d1e86 commit 2b427e1
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions tools/perf/builtin-stat.c
Original file line number Diff line number Diff line change
Expand Up @@ -492,11 +492,11 @@ static void print_stalled_cycles_frontend(int cpu, struct perf_evsel *evsel __us
ratio = avg / total * 100.0;

color = PERF_COLOR_NORMAL;
if (ratio > 75.0)
if (ratio > 50.0)
color = PERF_COLOR_RED;
else if (ratio > 50.0)
else if (ratio > 30.0)
color = PERF_COLOR_MAGENTA;
else if (ratio > 20.0)
else if (ratio > 10.0)
color = PERF_COLOR_YELLOW;

fprintf(stderr, " # ");
Expand All @@ -519,7 +519,7 @@ static void print_stalled_cycles_backend(int cpu, struct perf_evsel *evsel __use
color = PERF_COLOR_RED;
else if (ratio > 50.0)
color = PERF_COLOR_MAGENTA;
else if (ratio > 25.0)
else if (ratio > 20.0)
color = PERF_COLOR_YELLOW;

fprintf(stderr, " # ");
Expand Down

0 comments on commit 2b427e1

Please sign in to comment.