Skip to content

Commit

Permalink
KVM: use kvm_release_page_clean to release the page
Browse files Browse the repository at this point in the history
In kvm_async_pf_wakeup_all, it uses bad_page to generate broadcast wakeup,
and uses put_page to release bad_page, the work depends on the fact that
bad_page is the normal page. But we will use the error code instead of
bad_page, so use kvm_release_page_clean to release the page which will
release the error code properly

Signed-off-by: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Signed-off-by: Avi Kivity <avi@redhat.com>
  • Loading branch information
Xiao Guangrong authored and Avi Kivity committed Jul 26, 2012
1 parent 3b2bd2f commit 2b4b5af
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions virt/kvm/async_pf.c
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ void kvm_clear_async_pf_completion_queue(struct kvm_vcpu *vcpu)
typeof(*work), link);
list_del(&work->link);
if (work->page)
put_page(work->page);
kvm_release_page_clean(work->page);
kmem_cache_free(async_pf_cache, work);
}
spin_unlock(&vcpu->async_pf.lock);
Expand All @@ -139,7 +139,7 @@ void kvm_check_async_pf_completion(struct kvm_vcpu *vcpu)
list_del(&work->queue);
vcpu->async_pf.queued--;
if (work->page)
put_page(work->page);
kvm_release_page_clean(work->page);
kmem_cache_free(async_pf_cache, work);
}
}
Expand Down

0 comments on commit 2b4b5af

Please sign in to comment.