Skip to content

Commit

Permalink
Make ISDN CAPI use seq_list_xxx helpers
Browse files Browse the repository at this point in the history
The similar code exists here and is called capi_driver_get_idx().  Use generic
helpers now and remember to convert list_head to struct capi_driver in .show
callback.

Signed-off-by: Pavel Emelianov <xemul@openvz.org>
Acked-by: Karsten Keil <kkeil@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Pavel Emelianov authored and Linus Torvalds committed Jul 17, 2007
1 parent 6acee02 commit 2b7c302
Showing 1 changed file with 4 additions and 24 deletions.
28 changes: 4 additions & 24 deletions drivers/isdn/capi/kcapi_proc.c
Original file line number Diff line number Diff line change
Expand Up @@ -243,36 +243,15 @@ create_seq_entry(char *name, mode_t mode, const struct file_operations *f)

// ---------------------------------------------------------------------------


static __inline__ struct capi_driver *capi_driver_get_idx(loff_t pos)
{
struct capi_driver *drv = NULL;
struct list_head *l;
loff_t i;

i = 0;
list_for_each(l, &capi_drivers) {
drv = list_entry(l, struct capi_driver, list);
if (i++ == pos)
return drv;
}
return NULL;
}

static void *capi_driver_start(struct seq_file *seq, loff_t *pos)
{
struct capi_driver *drv;
read_lock(&capi_drivers_list_lock);
drv = capi_driver_get_idx(*pos);
return drv;
return seq_list_start(&capi_drivers, *pos);
}

static void *capi_driver_next(struct seq_file *seq, void *v, loff_t *pos)
{
struct capi_driver *drv = (struct capi_driver *)v;
++*pos;
if (drv->list.next == &capi_drivers) return NULL;
return list_entry(drv->list.next, struct capi_driver, list);
return seq_list_next(v, &capi_drivers, pos);
}

static void capi_driver_stop(struct seq_file *seq, void *v)
Expand All @@ -282,7 +261,8 @@ static void capi_driver_stop(struct seq_file *seq, void *v)

static int capi_driver_show(struct seq_file *seq, void *v)
{
struct capi_driver *drv = (struct capi_driver *)v;
struct capi_driver *drv = list_entry(v, struct capi_driver, list);

seq_printf(seq, "%-32s %s\n", drv->name, drv->revision);
return 0;
}
Expand Down

0 comments on commit 2b7c302

Please sign in to comment.