Skip to content

Commit

Permalink
ktest: Add option REBOOT_SUCCESS_LINE to stop waiting after a reboot
Browse files Browse the repository at this point in the history
When ktest.pl reboots, it will usuall wait SLEEP_TIME seconds of idle
console before starting the next test. By setting the
REBOOT_SUCCESS_LINE, ktest will not wait SLEEP_TIME when it detects the
line while rebooting to a new kernel.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
  • Loading branch information
Steven Rostedt authored and Steven Rostedt committed Oct 17, 2011
1 parent e0a8742 commit 2b80336
Show file tree
Hide file tree
Showing 2 changed files with 37 additions and 6 deletions.
33 changes: 27 additions & 6 deletions tools/testing/ktest/ktest.pl
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@
my $booted_timeout;
my $detect_triplefault;
my $console;
my $reboot_success_line;
my $success_line;
my $stop_after_success;
my $stop_after_failure;
Expand Down Expand Up @@ -612,6 +613,13 @@ sub doprint {
sub reboot {
my ($time) = @_;

if (defined($time)) {
start_monitor;
# flush out current monitor
# May contain the reboot success line
wait_for_monitor 1;
}

# try to reboot normally
if (run_command $reboot) {
if (defined($powercycle_after_reboot)) {
Expand All @@ -624,8 +632,7 @@ sub reboot {
}

if (defined($time)) {
start_monitor;
wait_for_monitor $time;
wait_for_monitor($time, $reboot_success_line);
end_monitor;
}
}
Expand Down Expand Up @@ -706,16 +713,29 @@ sub end_monitor {
}

sub wait_for_monitor {
my ($time) = @_;
my ($time, $stop) = @_;
my $full_line = "";
my $line;
my $booted = 0;

doprint "** Wait for monitor to settle down **\n";

# read the monitor and wait for the system to calm down
do {
while (!$booted) {
$line = wait_for_input($monitor_fp, $time);
print "$line" if (defined($line));
} while (defined($line));
last if (!defined($line));
print "$line";
$full_line .= $line;

if (defined($stop) && $full_line =~ /$stop/) {
doprint "wait for monitor detected $stop\n";
$booted = 1;
}

if ($line =~ /\n/) {
$full_line = "";
}
}
print "** Monitor flushed **\n";
}

Expand Down Expand Up @@ -2836,6 +2856,7 @@ sub set_test_option {
$console = set_test_option("CONSOLE", $i);
$detect_triplefault = set_test_option("DETECT_TRIPLE_FAULT", $i);
$success_line = set_test_option("SUCCESS_LINE", $i);
$reboot_success_line = set_test_option("REBOOT_SUCCESS_LINE", $i);
$stop_after_success = set_test_option("STOP_AFTER_SUCCESS", $i);
$stop_after_failure = set_test_option("STOP_AFTER_FAILURE", $i);
$stop_test_after = set_test_option("STOP_TEST_AFTER", $i);
Expand Down
10 changes: 10 additions & 0 deletions tools/testing/ktest/sample.conf
Original file line number Diff line number Diff line change
Expand Up @@ -423,6 +423,14 @@
# (default "login:")
#SUCCESS_LINE = login:

# To speed up between reboots, defining a line that the
# default kernel produces that represents that the default
# kernel has successfully booted and can be used to pass
# a new test kernel to it. Otherwise ktest.pl will wait till
# SLEEP_TIME to continue.
# (default undefined)
#REBOOT_SUCCESS_LINE = login:

# In case the console constantly fills the screen, having
# a specified time to stop the test after success is recommended.
# (in seconds)
Expand Down Expand Up @@ -488,6 +496,8 @@
# another test. If a reboot to the reliable kernel happens,
# we wait SLEEP_TIME for the console to stop producing output
# before starting the next test.
#
# You can speed up reboot times even more by setting REBOOT_SUCCESS_LINE.
# (default 60)
#SLEEP_TIME = 60

Expand Down

0 comments on commit 2b80336

Please sign in to comment.