Skip to content

Commit

Permalink
[media] radio-wl1273: Replace memcpy with struct assignment
Browse files Browse the repository at this point in the history
This kind of memcpy() is error-prone. Its replacement with a struct
assignment is prefered because it's type-safe and much easier to read.
Found by coccinelle. Hand patched and reviewed.
Tested by compilation only.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
identifier struct_name;
struct struct_name to;
struct struct_name from;
expression E;
@@
-memcpy(&(to), &(from), E);
+to = from;
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Ezequiel Garcia authored and Mauro Carvalho Chehab committed Dec 27, 2012
1 parent ee45ddc commit 2b9b325
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/media/radio/radio-wl1273.c
Original file line number Diff line number Diff line change
Expand Up @@ -2084,8 +2084,7 @@ static int __devinit wl1273_fm_radio_probe(struct platform_device *pdev)
}

/* V4L2 configuration */
memcpy(&radio->videodev, &wl1273_viddev_template,
sizeof(wl1273_viddev_template));
radio->videodev = wl1273_viddev_template;

radio->videodev.v4l2_dev = &radio->v4l2dev;

Expand Down

0 comments on commit 2b9b325

Please sign in to comment.