Skip to content

Commit

Permalink
trivial: doc: hpfall: reduce risk that hpfall can do harm
Browse files Browse the repository at this point in the history
Improve the example code to be at least useable, as in not causing
harm (as shown below). Code can still be improved further, but this
adds some basic safeguards.

1. hpfall *MUST* mlockall(MCL_CURRENT|MCL_FUTURE); itself!
Since the Program sits and waits most of the time it becomes very likely
swapped out. If it gets woken up when the laptop drops from the table
while it is swapped out it actually triggers harddrive activity!

2. Daemonize hpfall using 'daemon(0,0)' (quick and dirty).

3. Give hpfall realtime priority.
Should give a chance that it has less latency when woken up.

Signed-off-by: Christian Thaeter <ct@pipapo.org>
Signed-off-by: Frans Pop <elendil@planet.nl>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
  • Loading branch information
Christian Thaeter authored and Jiri Kosina committed Sep 21, 2009
1 parent 8103b5c commit 2bace8b
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions Documentation/hwmon/hpfall.c
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
#include <stdint.h>
#include <errno.h>
#include <signal.h>
#include <sys/mman.h>
#include <sched.h>

void write_int(char *path, int i)
{
Expand Down Expand Up @@ -62,13 +64,19 @@ void ignore_me(void)
int main(int argc, char *argv[])
{
int fd, ret;
struct sched_param param;

fd = open("/dev/freefall", O_RDONLY);
if (fd < 0) {
perror("open");
return EXIT_FAILURE;
}

daemon(0, 0);
param.sched_priority = sched_get_priority_max(SCHED_FIFO);
sched_setscheduler(0, SCHED_FIFO, &param);
mlockall(MCL_CURRENT|MCL_FUTURE);

signal(SIGALRM, ignore_me);

for (;;) {
Expand Down

0 comments on commit 2bace8b

Please sign in to comment.