Skip to content

Commit

Permalink
ftrace: use raw_smp_processor_id for mcount functions
Browse files Browse the repository at this point in the history
Due to debug hooks in the kernel that can change the way smp_processor_id
works, use raw_smp_processor_id in mcount called functions (namely
ftrace_record_ip). Currently we annotate most debug functions from calling
mcount, but we should not rely on that to prevent kernel lockups.

This patch uses the raw_smp_processor_id to prevent a recusive crash
that can happen if a debug hook in smp_processor_id calls mcount.

Signed-off-by: Steven Rostedt <srostedt@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
  • Loading branch information
Steven Rostedt authored and Thomas Gleixner committed May 23, 2008
1 parent a4feb83 commit 2bb6f8d
Showing 1 changed file with 11 additions and 4 deletions.
15 changes: 11 additions & 4 deletions kernel/trace/ftrace.c
Original file line number Diff line number Diff line change
Expand Up @@ -267,16 +267,23 @@ ftrace_record_ip(unsigned long ip)
unsigned long key;
int resched;
int atomic;
int cpu;

if (!ftrace_enabled || ftrace_disabled)
return;

resched = need_resched();
preempt_disable_notrace();

/* We simply need to protect against recursion */
__get_cpu_var(ftrace_shutdown_disable_cpu)++;
if (__get_cpu_var(ftrace_shutdown_disable_cpu) != 1)
/*
* We simply need to protect against recursion.
* Use the the raw version of smp_processor_id and not
* __get_cpu_var which can call debug hooks that can
* cause a recursive crash here.
*/
cpu = raw_smp_processor_id();
per_cpu(ftrace_shutdown_disable_cpu, cpu)++;
if (per_cpu(ftrace_shutdown_disable_cpu, cpu) != 1)
goto out;

if (unlikely(ftrace_record_suspend))
Expand Down Expand Up @@ -317,7 +324,7 @@ ftrace_record_ip(unsigned long ip)
out_unlock:
spin_unlock_irqrestore(&ftrace_shutdown_lock, flags);
out:
__get_cpu_var(ftrace_shutdown_disable_cpu)--;
per_cpu(ftrace_shutdown_disable_cpu, cpu)--;

/* prevent recursion with scheduler */
if (resched)
Expand Down

0 comments on commit 2bb6f8d

Please sign in to comment.