Skip to content

Commit

Permalink
hwmon: (pmbus) Increase attribute name size
Browse files Browse the repository at this point in the history
Some hwmon sysfs attributes have a length of 20 bytes (plus terminating 0).
I2C_NAME_SIZE is defined as 20 and thus can not be used to define the length
of hwmon sysfs attributes. Replace it with PMBUS_NAME_SIZE, set to 24.

Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
Reviewed-by: Robert Coulson <robert.coulson@ericsson.com>
  • Loading branch information
Guenter Roeck committed Jul 28, 2011
1 parent e0455e3 commit 2bd05bf
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions drivers/hwmon/pmbus/pmbus_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,10 @@
#define PB_STATUS_INPUT_BASE (PB_STATUS_FAN34_BASE + PMBUS_PAGES)
#define PB_STATUS_TEMP_BASE (PB_STATUS_INPUT_BASE + 1)

#define PMBUS_NAME_SIZE 24

struct pmbus_sensor {
char name[I2C_NAME_SIZE]; /* sysfs sensor name */
char name[PMBUS_NAME_SIZE]; /* sysfs sensor name */
struct sensor_device_attribute attribute;
u8 page; /* page number */
u8 reg; /* register */
Expand All @@ -86,14 +88,14 @@ struct pmbus_sensor {
};

struct pmbus_boolean {
char name[I2C_NAME_SIZE]; /* sysfs boolean name */
char name[PMBUS_NAME_SIZE]; /* sysfs boolean name */
struct sensor_device_attribute attribute;
};

struct pmbus_label {
char name[I2C_NAME_SIZE]; /* sysfs label name */
char name[PMBUS_NAME_SIZE]; /* sysfs label name */
struct sensor_device_attribute attribute;
char label[I2C_NAME_SIZE]; /* label */
char label[PMBUS_NAME_SIZE]; /* label */
};

struct pmbus_data {
Expand Down

0 comments on commit 2bd05bf

Please sign in to comment.