Skip to content

Commit

Permalink
[IPV4]: Snmpv2 Mib IP counter ipInAddrErrors support
Browse files Browse the repository at this point in the history
I followed Thomas' proposal to see every martian destination as a case
where the ipInAddrErrors counter has to be incremented. There are
two advantages by doing so: (1) The relation between the ipInReceive
counter and all the other ipInXXX counters is more accurate in the
case the RTN_UNICAST code check fails and (2) it makes the code in
ip_route_input_slow easier.

Signed-off-by: Dietmar Eggemann <dietmar.eggemann@gmx.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Dietmar Eggemann authored and David S. Miller committed Jun 28, 2005
1 parent ae9cda5 commit 2c2910a
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 3 deletions.
6 changes: 5 additions & 1 deletion net/ipv4/ip_input.c
Original file line number Diff line number Diff line change
Expand Up @@ -283,14 +283,18 @@ static inline int ip_rcv_finish(struct sk_buff *skb)
{
struct net_device *dev = skb->dev;
struct iphdr *iph = skb->nh.iph;
int err;

/*
* Initialise the virtual path cache for the packet. It describes
* how the packet travels inside Linux networking.
*/
if (skb->dst == NULL) {
if (ip_route_input(skb, iph->daddr, iph->saddr, iph->tos, dev))
if ((err = ip_route_input(skb, iph->daddr, iph->saddr, iph->tos, dev))) {
if (err == -EHOSTUNREACH)
IP_INC_STATS_BH(IPSTATS_MIB_INADDRERRORS);
goto drop;
}
}

#ifdef CONFIG_NET_CLS_ROUTE
Expand Down
9 changes: 7 additions & 2 deletions net/ipv4/route.c
Original file line number Diff line number Diff line change
Expand Up @@ -1909,7 +1909,7 @@ static int ip_route_input_slow(struct sk_buff *skb, u32 daddr, u32 saddr,
*/
if ((err = fib_lookup(&fl, &res)) != 0) {
if (!IN_DEV_FORWARD(in_dev))
goto e_inval;
goto e_hostunreach;
goto no_route;
}
free_res = 1;
Expand All @@ -1933,7 +1933,7 @@ static int ip_route_input_slow(struct sk_buff *skb, u32 daddr, u32 saddr,
}

if (!IN_DEV_FORWARD(in_dev))
goto e_inval;
goto e_hostunreach;
if (res.type != RTN_UNICAST)
goto martian_destination;

Expand Down Expand Up @@ -2025,6 +2025,11 @@ out: return err;
"%u.%u.%u.%u, dev %s\n",
NIPQUAD(daddr), NIPQUAD(saddr), dev->name);
#endif

e_hostunreach:
err = -EHOSTUNREACH;
goto done;

e_inval:
err = -EINVAL;
goto done;
Expand Down

0 comments on commit 2c2910a

Please sign in to comment.