Skip to content

Commit

Permalink
nfsd: per-net NFSd up flag introduced
Browse files Browse the repository at this point in the history
This patch introduces introduces per-net "nfsd_net_up" boolean flag, which has
the same purpose as general "nfsd_up" flag - skip init or shutdown of per-net
resources in case of they are inited on shutted down respectively.

Signed-off-by: Stanislav Kinsbursky <skinsbursky@parallels.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
  • Loading branch information
Stanislav Kinsbursky authored and J. Bruce Fields committed Dec 10, 2012
1 parent 6ff50b3 commit 2c2fe29
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 0 deletions.
2 changes: 2 additions & 0 deletions fs/nfsd/netns.h
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,8 @@ struct nfsd_net {

time_t nfsd4_lease;
time_t nfsd4_grace;

bool nfsd_net_up;
};

/* Simple check to find out if a given net was properly initialized */
Expand Down
12 changes: 12 additions & 0 deletions fs/nfsd/nfssvc.c
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
#include "nfsd.h"
#include "cache.h"
#include "vfs.h"
#include "netns.h"

#define NFSDDBG_FACILITY NFSDDBG_SVC

Expand Down Expand Up @@ -205,8 +206,12 @@ static bool nfsd_up = false;

static int nfsd_startup_net(struct net *net)
{
struct nfsd_net *nn = net_generic(net, nfsd_net_id);
int ret;

if (nn->nfsd_net_up)
return 0;

ret = nfsd_init_socks(net);
if (ret)
return ret;
Expand All @@ -217,6 +222,7 @@ static int nfsd_startup_net(struct net *net)
if (ret)
goto out_lockd;

nn->nfsd_net_up = true;
return 0;

out_lockd:
Expand Down Expand Up @@ -257,8 +263,14 @@ static int nfsd_startup(int nrservs, struct net *net)

static void nfsd_shutdown_net(struct net *net)
{
struct nfsd_net *nn = net_generic(net, nfsd_net_id);

if (!nn->nfsd_net_up)
return;

nfs4_state_shutdown_net(net);
lockd_down(net);
nn->nfsd_net_up = false;
}

static void nfsd_shutdown(struct net *net)
Expand Down

0 comments on commit 2c2fe29

Please sign in to comment.