Skip to content

Commit

Permalink
staging: line6: change monitor_level type ValueWait -> int
Browse files Browse the repository at this point in the history
The monitor_level sysfs attr has been dropped and we never need to wait
on the monitor_level value to change.  Switch to a plain int and drop
the wait queue.

Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Stefan Hajnoczi authored and Greg Kroah-Hartman committed Nov 27, 2012
1 parent 410cefa commit 2c35dc2
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
10 changes: 5 additions & 5 deletions drivers/staging/line6/pod.c
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ void line6_pod_process_message(struct usb_line6_pod *pod)

switch (buf[6]) {
case POD_monitor_level:
pod->monitor_level.value = value;
pod->monitor_level = value;
break;

PROCESS_SYSTEM_PARAM(routing);
Expand Down Expand Up @@ -908,7 +908,7 @@ static int snd_pod_control_monitor_get(struct snd_kcontrol *kcontrol,
{
struct snd_line6_pcm *line6pcm = snd_kcontrol_chip(kcontrol);
struct usb_line6_pod *pod = (struct usb_line6_pod *)line6pcm->line6;
ucontrol->value.integer.value[0] = pod->monitor_level.value;
ucontrol->value.integer.value[0] = pod->monitor_level;
return 0;
}

Expand All @@ -919,10 +919,10 @@ static int snd_pod_control_monitor_put(struct snd_kcontrol *kcontrol,
struct snd_line6_pcm *line6pcm = snd_kcontrol_chip(kcontrol);
struct usb_line6_pod *pod = (struct usb_line6_pod *)line6pcm->line6;

if (ucontrol->value.integer.value[0] == pod->monitor_level.value)
if (ucontrol->value.integer.value[0] == pod->monitor_level)
return 0;

pod->monitor_level.value = ucontrol->value.integer.value[0];
pod->monitor_level = ucontrol->value.integer.value[0];
pod_set_system_param_int(pod, ucontrol->value.integer.value[0],
POD_monitor_level);
return 1;
Expand Down Expand Up @@ -1053,7 +1053,7 @@ static int pod_try_init(struct usb_interface *interface,
*/

if (pod->line6.properties->capabilities & LINE6_BIT_CONTROL) {
pod->monitor_level.value = POD_system_invalid;
pod->monitor_level = POD_system_invalid;

/* initiate startup procedure: */
pod_startup1(pod);
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/line6/pod.h
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ struct usb_line6_pod {
/**
Instrument monitor level.
*/
struct ValueWait monitor_level;
int monitor_level;

/**
Audio routing mode.
Expand Down

0 comments on commit 2c35dc2

Please sign in to comment.