Skip to content

Commit

Permalink
[S390] improve suspend/resume error messages
Browse files Browse the repository at this point in the history
From: Michael Holzheu <holzheu@linux.vnet.ibm.com>

Signed-off-by: Michael Holzheu <holzheu@linux.vnet.ibm.com>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
  • Loading branch information
Christian Borntraeger authored and Martin Schwidefsky committed Jul 7, 2009
1 parent fca3e35 commit 2c48c4d
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 8 deletions.
7 changes: 4 additions & 3 deletions drivers/s390/block/dcssblk.c
Original file line number Diff line number Diff line change
Expand Up @@ -964,7 +964,8 @@ static int dcssblk_freeze(struct device *dev)
break;
}
if (rc)
pr_err("Suspend failed because device %s is writeable.\n",
pr_err("Suspending the system failed because DCSS device %s "
"is writable\n",
dev_info->segment_name);
return rc;
}
Expand All @@ -987,8 +988,8 @@ static int dcssblk_restore(struct device *dev)
goto out_panic;
}
if (start != entry->start || end != entry->end) {
pr_err("Mismatch of start / end address after "
"resuming device %s\n",
pr_err("The address range of DCSS %s changed "
"while the system was suspended\n",
entry->segment_name);
goto out_panic;
}
Expand Down
2 changes: 1 addition & 1 deletion drivers/s390/block/xpram.c
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,7 @@ static int xpram_validate_checksums(void)
*/
static void xpram_resume_error(const char *message)
{
pr_err("Resume error: %s\n", message);
pr_err("Resuming the system failed: %s\n", message);
panic("xpram resume error\n");
}

Expand Down
8 changes: 4 additions & 4 deletions drivers/s390/char/vmwatchdog.c
Original file line number Diff line number Diff line change
Expand Up @@ -250,14 +250,14 @@ static int vmwdt_resume(void)
static int vmwdt_suspend(void)
{
if (test_and_set_bit(VMWDT_OPEN, &vmwdt_is_open)) {
pr_err("The watchdog is in use. "
"This prevents hibernation or suspend.\n");
pr_err("The system cannot be suspended while the watchdog"
" is in use\n");
return NOTIFY_BAD;
}
if (test_bit(VMWDT_RUNNING, &vmwdt_is_open)) {
clear_bit(VMWDT_OPEN, &vmwdt_is_open);
pr_err("The watchdog is running. "
"This prevents hibernation or suspend.\n");
pr_err("The system cannot be suspended while the watchdog"
" is running\n");
return NOTIFY_BAD;
}
return NOTIFY_DONE;
Expand Down

0 comments on commit 2c48c4d

Please sign in to comment.