Skip to content

Commit

Permalink
clk: sunxi: Remove calls to clk_put
Browse files Browse the repository at this point in the history
Callers of clk_put must disable the clock first. This also means that
as long as the clock is enabled the driver should hold a reference to
that clock. Hence, the call to clk_put here are bogus and should be
removed.

Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Acked-by: Mike Turquette <mturquette@linaro.org>
Signed-off-by: Emilio López <emilio@elopez.com.ar>
  • Loading branch information
Maxime Ripard committed Jun 11, 2014
1 parent 6d1d14d commit 2c6fba1
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions drivers/clk/sunxi/clk-sunxi.c
Original file line number Diff line number Diff line change
Expand Up @@ -1339,17 +1339,13 @@ static void __init sunxi_clock_protect(void)

/* memory bus clock - sun5i+ */
clk = clk_get(NULL, "mbus");
if (!IS_ERR(clk)) {
if (!IS_ERR(clk))
clk_prepare_enable(clk);
clk_put(clk);
}

/* DDR clock - sun4i+ */
clk = clk_get(NULL, "pll5_ddr");
if (!IS_ERR(clk)) {
if (!IS_ERR(clk))
clk_prepare_enable(clk);
clk_put(clk);
}
}

static void __init sunxi_init_clocks(struct device_node *np)
Expand Down

0 comments on commit 2c6fba1

Please sign in to comment.