Skip to content

Commit

Permalink
[media] Correct error code from -ENOMEM to -EINVAL.
Browse files Browse the repository at this point in the history
Make sure the return value is set in all cases

>From 9b38a5c9878b5e4be2899ae291c4524f5f5fc218 Mon Sep 17 00:00:00 2001

Signed-off-by: Hans Petter Selasky <hselasky@c2i.net>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Hans Petter Selasky authored and Mauro Carvalho Chehab committed Jul 27, 2011
1 parent 5588dc2 commit 2c7988a
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions drivers/media/video/sr030pc30.c
Original file line number Diff line number Diff line change
Expand Up @@ -726,8 +726,10 @@ static int sr030pc30_s_power(struct v4l2_subdev *sd, int on)
const struct sr030pc30_platform_data *pdata = info->pdata;
int ret;

if (WARN(pdata == NULL, "No platform data!\n"))
return -ENOMEM;
if (pdata == NULL) {
WARN(1, "No platform data!\n");
return -EINVAL;
}

/*
* Put sensor into power sleep mode before switching off
Expand All @@ -746,6 +748,7 @@ static int sr030pc30_s_power(struct v4l2_subdev *sd, int on)
if (on) {
ret = sr030pc30_base_config(sd);
} else {
ret = 0;
info->curr_win = NULL;
info->curr_fmt = NULL;
}
Expand Down

0 comments on commit 2c7988a

Please sign in to comment.