Skip to content

Commit

Permalink
perf tools: Move get_term_dimensions from top to util.c
Browse files Browse the repository at this point in the history
It is used by util/help.c so it should be a lib function and included in
libperf.a. Code move only.

Signed-off-by: David Ahern <dsahern@gmail.com>
Link: http://lkml.kernel.org/r/1358185681-90926-1-git-send-email-dsahern@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  • Loading branch information
David Ahern authored and Arnaldo Carvalho de Melo committed Jan 24, 2013
1 parent b7c14a0 commit 2c803e5
Show file tree
Hide file tree
Showing 4 changed files with 25 additions and 26 deletions.
22 changes: 0 additions & 22 deletions tools/perf/builtin-top.c
Original file line number Diff line number Diff line change
Expand Up @@ -68,28 +68,6 @@
#include <linux/unistd.h>
#include <linux/types.h>

void get_term_dimensions(struct winsize *ws)
{
char *s = getenv("LINES");

if (s != NULL) {
ws->ws_row = atoi(s);
s = getenv("COLUMNS");
if (s != NULL) {
ws->ws_col = atoi(s);
if (ws->ws_row && ws->ws_col)
return;
}
}
#ifdef TIOCGWINSZ
if (ioctl(1, TIOCGWINSZ, ws) == 0 &&
ws->ws_row && ws->ws_col)
return;
#endif
ws->ws_row = 25;
ws->ws_col = 80;
}

static void perf_top__update_print_entries(struct perf_top *top)
{
if (top->print_entries > 9)
Expand Down
4 changes: 0 additions & 4 deletions tools/perf/perf.h
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
#ifndef _PERF_PERF_H
#define _PERF_PERF_H

struct winsize;

void get_term_dimensions(struct winsize *ws);

#include <asm/unistd.h>

#if defined(__i386__)
Expand Down
22 changes: 22 additions & 0 deletions tools/perf/util/util.c
Original file line number Diff line number Diff line change
Expand Up @@ -220,3 +220,25 @@ void dump_stack(void)
#else
void dump_stack(void) {}
#endif

void get_term_dimensions(struct winsize *ws)
{
char *s = getenv("LINES");

if (s != NULL) {
ws->ws_row = atoi(s);
s = getenv("COLUMNS");
if (s != NULL) {
ws->ws_col = atoi(s);
if (ws->ws_row && ws->ws_col)
return;
}
}
#ifdef TIOCGWINSZ
if (ioctl(1, TIOCGWINSZ, ws) == 0 &&
ws->ws_row && ws->ws_col)
return;
#endif
ws->ws_row = 25;
ws->ws_col = 80;
}
3 changes: 3 additions & 0 deletions tools/perf/util/util.h
Original file line number Diff line number Diff line change
Expand Up @@ -271,4 +271,7 @@ void dump_stack(void);

extern unsigned int page_size;

struct winsize;
void get_term_dimensions(struct winsize *ws);

#endif

0 comments on commit 2c803e5

Please sign in to comment.