Skip to content

Commit

Permalink
GPIO: clps711x: use platform_device_unregister in gpio_clps711x_init()
Browse files Browse the repository at this point in the history
platform_device_unregister() only calls platform_device_del() and
platform_device_put(), thus use platform_device_unregister() to
simplify the code.

Also the documents in platform.c shows that platform_device_del
and platform_device_put must _only_ be externally called in error
cases.  All other usage is a bug.

dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
  • Loading branch information
Wei Yongjun authored and Linus Walleij committed Oct 27, 2012
1 parent a362605 commit 2cad6a8
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/gpio/gpio-clps711x.c
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,7 @@ static int __init gpio_clps711x_init(void)
GFP_KERNEL);
if (!gpio) {
dev_err(&pdev->dev, "GPIO allocating memory error\n");
platform_device_del(pdev);
platform_device_put(pdev);
platform_device_unregister(pdev);
return -ENOMEM;
}

Expand Down

0 comments on commit 2cad6a8

Please sign in to comment.