Skip to content

Commit

Permalink
zram: Fix sparse warnings
Browse files Browse the repository at this point in the history
Fixes sparse warning:
zram_drv.c:666:6: warning: symbol 'zram_slot_free_notify' was not
declared. Should it be static?

Also, max_zpage_size is now size_t just to be consistent with data-type
of other variables maintaining sizes of various kinds.

Signed-off-by: Nitin Gupta <ngupta@vflare.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Nitin Gupta authored and Greg Kroah-Hartman committed Sep 9, 2011
1 parent 25d7315 commit 2ccbec0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion drivers/staging/zram/zram_drv.c
Original file line number Diff line number Diff line change
Expand Up @@ -697,7 +697,8 @@ int zram_init_device(struct zram *zram)
return ret;
}

void zram_slot_free_notify(struct block_device *bdev, unsigned long index)
static void zram_slot_free_notify(struct block_device *bdev,
unsigned long index)
{
struct zram *zram;

Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/zram/zram_drv.h
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ static const unsigned default_disksize_perc_ram = 25;
* Pages that compress to size greater than this are stored
* uncompressed in memory.
*/
static const unsigned max_zpage_size = PAGE_SIZE / 4 * 3;
static const size_t max_zpage_size = PAGE_SIZE / 4 * 3;

/*
* NOTE: max_zpage_size must be less than or equal to:
Expand Down

0 comments on commit 2ccbec0

Please sign in to comment.