Skip to content

Commit

Permalink
parisc: add braces around arguments in assembler macros
Browse files Browse the repository at this point in the history
Add braces around the macro arguments, else for example
"shl %r1, 5-3, %r2" would not expand to what you would assume.

Signed-off-by: Helge Deller <deller@gmx.de>
Signed-off-by: Kyle McMartin <kyle@mcmartin.ca>
  • Loading branch information
Helge Deller authored and Kyle McMartin committed Mar 13, 2009
1 parent 7f384ce commit 2cfeb9a
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
10 changes: 5 additions & 5 deletions arch/parisc/include/asm/assembly.h
Original file line number Diff line number Diff line change
Expand Up @@ -129,27 +129,27 @@

/* Shift Left - note the r and t can NOT be the same! */
.macro shl r, sa, t
dep,z \r, 31-\sa, 32-\sa, \t
dep,z \r, 31-(\sa), 32-(\sa), \t
.endm

/* The PA 2.0 shift left */
.macro shlw r, sa, t
depw,z \r, 31-\sa, 32-\sa, \t
depw,z \r, 31-(\sa), 32-(\sa), \t
.endm

/* And the PA 2.0W shift left */
.macro shld r, sa, t
depd,z \r, 63-\sa, 64-\sa, \t
depd,z \r, 63-(\sa), 64-(\sa), \t
.endm

/* Shift Right - note the r and t can NOT be the same! */
.macro shr r, sa, t
extru \r, 31-\sa, 32-\sa, \t
extru \r, 31-(\sa), 32-(\sa), \t
.endm

/* pa20w version of shift right */
.macro shrd r, sa, t
extrd,u \r, 63-\sa, 64-\sa, \t
extrd,u \r, 63-(\sa), 64-(\sa), \t
.endm

/* load 32-bit 'value' into 'reg' compensating for the ldil
Expand Down
6 changes: 3 additions & 3 deletions arch/parisc/kernel/entry.S
Original file line number Diff line number Diff line change
Expand Up @@ -368,23 +368,23 @@
* abstractions for the macros */
.macro EXTR reg1,start,length,reg2
#ifdef CONFIG_64BIT
extrd,u \reg1,32+\start,\length,\reg2
extrd,u \reg1,32+(\start),\length,\reg2
#else
extrw,u \reg1,\start,\length,\reg2
#endif
.endm

.macro DEP reg1,start,length,reg2
#ifdef CONFIG_64BIT
depd \reg1,32+\start,\length,\reg2
depd \reg1,32+(\start),\length,\reg2
#else
depw \reg1,\start,\length,\reg2
#endif
.endm

.macro DEPI val,start,length,reg
#ifdef CONFIG_64BIT
depdi \val,32+\start,\length,\reg
depdi \val,32+(\start),\length,\reg
#else
depwi \val,\start,\length,\reg
#endif
Expand Down

0 comments on commit 2cfeb9a

Please sign in to comment.