Skip to content

Commit

Permalink
usb: dwc2: remove dwc2_platform.ko
Browse files Browse the repository at this point in the history
As dwc2 pci module is now exporting dwc2 platform device, include
platform.o in dwc2-y and remove USB_DWC2_PLATFORM configuration
option. Driver will be built as two modules, dwc2.ko and dwc2_pci.ko.
dwc2.ko is the new platform driver.

Remove all EXPORT_SYMBOL_GPL as they are not needed any more.

Acked-by: John Youn <johnyoun@synopsys.com>
Signed-off-by: Mian Yousaf Kaukab <yousaf.kaukab@intel.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
  • Loading branch information
Mian Yousaf Kaukab authored and Felipe Balbi committed Apr 29, 2015
1 parent 96d480e commit 2d1165a
Show file tree
Hide file tree
Showing 7 changed files with 1 addition and 25 deletions.
8 changes: 0 additions & 8 deletions drivers/usb/dwc2/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -50,18 +50,10 @@ config USB_DWC2_DUAL_ROLE
option requires USB_GADGET to be enabled.
endchoice

config USB_DWC2_PLATFORM
tristate "DWC2 Platform"
default USB_DWC2_HOST || USB_DWC2_PERIPHERAL
help
The Designware USB2.0 platform interface module for
controllers directly connected to the CPU.

config USB_DWC2_PCI
tristate "DWC2 PCI"
depends on PCI
default n
select USB_DWC2_PLATFORM
select NOP_USB_XCEIV
help
The Designware USB2.0 PCI interface module for controllers
Expand Down
5 changes: 1 addition & 4 deletions drivers/usb/dwc2/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ ccflags-$(CONFIG_USB_DWC2_DEBUG) += -DDEBUG
ccflags-$(CONFIG_USB_DWC2_VERBOSE) += -DVERBOSE_DEBUG

obj-$(CONFIG_USB_DWC2) += dwc2.o
dwc2-y := core.o core_intr.o
dwc2-y := core.o core_intr.o platform.o

ifneq ($(filter y,$(CONFIG_USB_DWC2_HOST) $(CONFIG_USB_DWC2_DUAL_ROLE)),)
dwc2-y += hcd.o hcd_intr.o
Expand All @@ -25,6 +25,3 @@ endif

obj-$(CONFIG_USB_DWC2_PCI) += dwc2_pci.o
dwc2_pci-y := pci.o

obj-$(CONFIG_USB_DWC2_PLATFORM) += dwc2_platform.o
dwc2_platform-y := platform.o
3 changes: 0 additions & 3 deletions drivers/usb/dwc2/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -3044,7 +3044,6 @@ void dwc2_set_parameters(struct dwc2_hsotg *hsotg,
dwc2_set_param_uframe_sched(hsotg, params->uframe_sched);
dwc2_set_param_external_id_pin_ctl(hsotg, params->external_id_pin_ctl);
}
EXPORT_SYMBOL_GPL(dwc2_set_parameters);

/**
* During device initialization, read various hardware configuration
Expand Down Expand Up @@ -3211,7 +3210,6 @@ int dwc2_get_hwparams(struct dwc2_hsotg *hsotg)

return 0;
}
EXPORT_SYMBOL_GPL(dwc2_get_hwparams);

/*
* Sets all parameters to the given value.
Expand All @@ -3227,7 +3225,6 @@ void dwc2_set_all_params(struct dwc2_core_params *params, int value)
for (i = 0; i < size; i++)
p[i] = value;
}
EXPORT_SYMBOL_GPL(dwc2_set_all_params);


u16 dwc2_get_otg_version(struct dwc2_hsotg *hsotg)
Expand Down
1 change: 0 additions & 1 deletion drivers/usb/dwc2/core_intr.c
Original file line number Diff line number Diff line change
Expand Up @@ -559,4 +559,3 @@ irqreturn_t dwc2_handle_common_intr(int irq, void *dev)
spin_unlock(&hsotg->lock);
return retval;
}
EXPORT_SYMBOL_GPL(dwc2_handle_common_intr);
2 changes: 0 additions & 2 deletions drivers/usb/dwc2/debugfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -763,11 +763,9 @@ int dwc2_debugfs_init(struct dwc2_hsotg *hsotg)
err0:
return ret;
}
EXPORT_SYMBOL_GPL(dwc2_debugfs_init);

void dwc2_debugfs_exit(struct dwc2_hsotg *hsotg)
{
debugfs_remove_recursive(hsotg->debug_root);
hsotg->debug_root = NULL;
}
EXPORT_SYMBOL_GPL(dwc2_debugfs_exit);
5 changes: 0 additions & 5 deletions drivers/usb/dwc2/gadget.c
Original file line number Diff line number Diff line change
Expand Up @@ -2190,7 +2190,6 @@ void s3c_hsotg_disconnect(struct dwc2_hsotg *hsotg)

call_gadget(hsotg, disconnect);
}
EXPORT_SYMBOL_GPL(s3c_hsotg_disconnect);

/**
* s3c_hsotg_irq_fifoempty - TX FIFO empty interrupt handler
Expand Down Expand Up @@ -3666,7 +3665,6 @@ int dwc2_gadget_init(struct dwc2_hsotg *hsotg, int irq)

return ret;
}
EXPORT_SYMBOL_GPL(dwc2_gadget_init);

/**
* s3c_hsotg_remove - remove function for hsotg driver
Expand All @@ -3679,7 +3677,6 @@ int s3c_hsotg_remove(struct dwc2_hsotg *hsotg)

return 0;
}
EXPORT_SYMBOL_GPL(s3c_hsotg_remove);

int s3c_hsotg_suspend(struct dwc2_hsotg *hsotg)
{
Expand Down Expand Up @@ -3722,7 +3719,6 @@ int s3c_hsotg_suspend(struct dwc2_hsotg *hsotg)

return ret;
}
EXPORT_SYMBOL_GPL(s3c_hsotg_suspend);

int s3c_hsotg_resume(struct dwc2_hsotg *hsotg)
{
Expand Down Expand Up @@ -3754,4 +3750,3 @@ int s3c_hsotg_resume(struct dwc2_hsotg *hsotg)

return ret;
}
EXPORT_SYMBOL_GPL(s3c_hsotg_resume);
2 changes: 0 additions & 2 deletions drivers/usb/dwc2/hcd.c
Original file line number Diff line number Diff line change
Expand Up @@ -2980,7 +2980,6 @@ int dwc2_hcd_init(struct dwc2_hsotg *hsotg, int irq)
dev_err(hsotg->dev, "%s() FAILED, returning %d\n", __func__, retval);
return retval;
}
EXPORT_SYMBOL_GPL(dwc2_hcd_init);

/*
* Removes the HCD.
Expand Down Expand Up @@ -3014,4 +3013,3 @@ void dwc2_hcd_remove(struct dwc2_hsotg *hsotg)
kfree(hsotg->frame_num_array);
#endif
}
EXPORT_SYMBOL_GPL(dwc2_hcd_remove);

0 comments on commit 2d1165a

Please sign in to comment.