Skip to content

Commit

Permalink
S2io: two branches the same in wait_for_cmd_complete()
Browse files Browse the repository at this point in the history
Fix check to verify if a register bit is set. We have not hit this bug because
wait_for_cmd_complete() is always called with S2IO_BIT_RESET. 
Reported by Roel Kluin <roel.kluin@gmail.com>.

Signed-off-by: Ram Vepa <ram.vepa@neterion.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Ram Vepa authored and David S. Miller committed Jan 19, 2010
1 parent dad48a4 commit 2d146eb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/s2io.c
Original file line number Diff line number Diff line change
Expand Up @@ -3421,7 +3421,7 @@ static int wait_for_cmd_complete(void __iomem *addr, u64 busy_bit,
break;
}
} else {
if (!(val64 & busy_bit)) {
if (val64 & busy_bit) {
ret = SUCCESS;
break;
}
Expand Down

0 comments on commit 2d146eb

Please sign in to comment.