Skip to content

Commit

Permalink
Merge branch 'bugzilla-12249' into release
Browse files Browse the repository at this point in the history
  • Loading branch information
Len Brown committed Apr 24, 2009
2 parents 04a2e62 + e047cca commit 2d40570
Showing 1 changed file with 22 additions and 21 deletions.
43 changes: 22 additions & 21 deletions drivers/acpi/video.c
Original file line number Diff line number Diff line change
Expand Up @@ -809,38 +809,39 @@ acpi_video_init_brightness(struct acpi_video_device *device)
br->flags._BCM_use_index = br->flags._BCL_use_index;

/* _BQC uses INDEX while _BCL uses VALUE in some laptops */
br->curr = max_level;
br->curr = level_old = max_level;

if (!device->cap._BQC)
goto set_level;

result = acpi_video_device_lcd_get_level_current(device, &level_old);
if (result)
goto out_free_levels;

result = acpi_video_device_lcd_set_level(device, br->curr);
/*
* Set the level to maximum and check if _BQC uses indexed value
*/
result = acpi_video_device_lcd_set_level(device, max_level);
if (result)
goto out_free_levels;

result = acpi_video_device_lcd_get_level_current(device, &level);
if (result)
goto out_free_levels;

if ((level != level_old) && !br->flags._BCM_use_index) {
/* Note:
* This piece of code does not work correctly if the current
* brightness levels is 0.
* But I guess boxes that boot with such a dark screen are rare
* and no more code is needed to cover this specifial case.
*/

if (level_ac_battery != 2) {
/*
* For now, we don't support the _BCL like this:
* 16, 15, 0, 1, 2, 3, ..., 14, 15, 16
* because we may mess up the index returned by _BQC.
* Plus: we have not got a box like this.
*/
ACPI_ERROR((AE_INFO, "_BCL not supported\n"));
}
br->flags._BQC_use_index = 1;
}
br->flags._BQC_use_index = (level == max_level ? 0 : 1);

if (!br->flags._BQC_use_index)
goto set_level;

if (br->flags._BCL_reversed)
level_old = (br->count - 1) - level_old;
level_old = br->levels[level_old];

set_level:
result = acpi_video_device_lcd_set_level(device, level_old);
if (result)
goto out_free_levels;

ACPI_DEBUG_PRINT((ACPI_DB_INFO,
"found %d brightness levels\n", count - 2));
Expand Down

0 comments on commit 2d40570

Please sign in to comment.