Skip to content

Commit

Permalink
be2net: Fix a potential crash during shutdown.
Browse files Browse the repository at this point in the history
adapter could remain uninitialized if probe fails for some reason.
A null pointer access could cause a crash if be_shutdown
is called after that.

Signed-off-by: Ajit Khaparde <ajit.khaparde@emulex.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Ajit Khaparde authored and David S. Miller committed Apr 6, 2011
1 parent 1e58148 commit 2d5d415
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions drivers/net/benet/be_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -3141,12 +3141,14 @@ static int be_resume(struct pci_dev *pdev)
static void be_shutdown(struct pci_dev *pdev)
{
struct be_adapter *adapter = pci_get_drvdata(pdev);
struct net_device *netdev = adapter->netdev;

if (netif_running(netdev))
if (!adapter)
return;

if (netif_running(adapter->netdev))
cancel_delayed_work_sync(&adapter->work);

netif_device_detach(netdev);
netif_device_detach(adapter->netdev);

be_cmd_reset_function(adapter);

Expand Down

0 comments on commit 2d5d415

Please sign in to comment.