Skip to content

Commit

Permalink
Staging: batman-adv: Mark debugfs files as nonseekable
Browse files Browse the repository at this point in the history
We don't allow to seek in the debugfs socket and log files. Thus we
should mark the file descriptor as nonseekable.

Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Sven Eckelmann authored and Greg Kroah-Hartman committed Sep 20, 2010
1 parent 93b3d9d commit 2d77bb5
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
2 changes: 2 additions & 0 deletions drivers/staging/batman-adv/bat_debugfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ int debug_log(struct bat_priv *bat_priv, char *fmt, ...)

static int log_open(struct inode *inode, struct file *file)
{
nonseekable_open(inode, file);
file->private_data = inode->i_private;
inc_module_count();
return 0;
Expand Down Expand Up @@ -174,6 +175,7 @@ static const struct file_operations log_fops = {
.release = log_release,
.read = log_read,
.poll = log_poll,
.llseek = no_llseek,
};

static int debug_log_setup(struct bat_priv *bat_priv)
Expand Down
3 changes: 3 additions & 0 deletions drivers/staging/batman-adv/icmp_socket.c
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ static int bat_socket_open(struct inode *inode, struct file *file)
unsigned int i;
struct socket_client *socket_client;

nonseekable_open(inode, file);

socket_client = kmalloc(sizeof(struct socket_client), GFP_KERNEL);

if (!socket_client)
Expand Down Expand Up @@ -283,6 +285,7 @@ static const struct file_operations fops = {
.read = bat_socket_read,
.write = bat_socket_write,
.poll = bat_socket_poll,
.llseek = no_llseek,
};

int bat_socket_setup(struct bat_priv *bat_priv)
Expand Down

0 comments on commit 2d77bb5

Please sign in to comment.