Skip to content

Commit

Permalink
Staging: rc2860: return -EFAULT on copy_to_user errors
Browse files Browse the repository at this point in the history
copy_to_user() returns the number of bytes remaining but we want to
return a negative error code.  This is in the ioctl handler and the
error code gets passed to userspace.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Dan Carpenter authored and Greg Kroah-Hartman committed Jun 4, 2010
1 parent c60e55f commit 2d98bb2
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions drivers/staging/rt2860/sta_ioctl.c
Original file line number Diff line number Diff line change
Expand Up @@ -2522,6 +2522,8 @@ int rt28xx_sta_ioctl(IN struct net_device *net_dev,
Status =
copy_to_user(erq->pointer, pAd->nickname,
erq->length);
if (Status)
Status = -EFAULT;
break;
}
case SIOCGIWRATE: /*get default bit rate (bps) */
Expand Down

0 comments on commit 2d98bb2

Please sign in to comment.