Skip to content

Commit

Permalink
USB: cp210x: use generic submit_read_urb at open
Browse files Browse the repository at this point in the history
There is no need to initialise the read urb as this is done at port
probe.

Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Johan Hovold authored and Greg Kroah-Hartman committed May 20, 2010
1 parent 056afc0 commit 2db6c76
Showing 1 changed file with 2 additions and 14 deletions.
16 changes: 2 additions & 14 deletions drivers/usb/serial/cp210x.c
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,6 @@ static unsigned int cp210x_quantise_baudrate(unsigned int baud) {

static int cp210x_open(struct tty_struct *tty, struct usb_serial_port *port)
{
struct usb_serial *serial = port->serial;
int result;

dbg("%s - port %d", __func__, port->number);
Expand All @@ -383,20 +382,9 @@ static int cp210x_open(struct tty_struct *tty, struct usb_serial_port *port)
return -EPROTO;
}

/* Start reading from the device */
usb_fill_bulk_urb(port->read_urb, serial->dev,
usb_rcvbulkpipe(serial->dev,
port->bulk_in_endpointAddress),
port->read_urb->transfer_buffer,
port->read_urb->transfer_buffer_length,
serial->type->read_bulk_callback,
port);
result = usb_submit_urb(port->read_urb, GFP_KERNEL);
if (result) {
dev_err(&port->dev, "%s - failed resubmitting read urb, "
"error %d\n", __func__, result);
result = usb_serial_generic_submit_read_urb(port, GFP_KERNEL);
if (result)
return result;
}

/* Configure the termios structure */
cp210x_get_termios(tty, port);
Expand Down

0 comments on commit 2db6c76

Please sign in to comment.