Skip to content

Commit

Permalink
HID: make full-fledged hid-bus drivers properly selectable
Browse files Browse the repository at this point in the history
For historical reasons, we don't have most of the in-tree
drivers residing on hid-bus properly selectable in kernel
configuration unless CONFIG_EMBEDDED is set.

This has been introduced on Linus' request from 14 Oct

===
As to the Kconfig options - do they really add so much space that you need to
ask for the quirks? You didn't use to. Can you make the questions depend on
EMBEDDED, or at least on the HID_COMPAT thing or whatever?
===

This still makes perfect sense for small and tiny drivers, which
just fix report descriptors, fix up HID->input mappings that slightly
violates HUT standard, send one extra packet to the device that is
needed before it becomes functional, etc.

Since then, we have been gathering more and more HID-bus drivers,
which are full-fledged drivers. For these, the size argument becomes
more valid. Plus the devices are much more special than "just violates
HID specification in this one or two tiny unimportant points".

Therefore I am marking such drivers as properly selectable no matter
the setting of CONFIG_EMBEDDED, while keeping all the small and tiny
ones compiled by default.

Signed-off-by: Jiri Kosina <jkosina@suse.cz>
  • Loading branch information
Jiri Kosina committed Feb 3, 2010
1 parent f54405d commit 2dbf209
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions drivers/hid/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -212,9 +212,8 @@ config HID_MONTEREY
Support for Monterey Genius KB29E.

config HID_NTRIG
tristate "NTrig" if EMBEDDED
tristate "NTrig"
depends on USB_HID
default !EMBEDDED
---help---
Support for N-Trig touch screen.

Expand Down Expand Up @@ -338,9 +337,8 @@ config THRUSTMASTER_FF
Rumble Force or Force Feedback Wheel.

config HID_WACOM
tristate "Wacom Bluetooth devices support" if EMBEDDED
tristate "Wacom Bluetooth devices support"
depends on BT_HIDP
default !EMBEDDED
---help---
Support for Wacom Graphire Bluetooth tablet.

Expand Down

0 comments on commit 2dbf209

Please sign in to comment.