Skip to content

Commit

Permalink
RTC: rtc-omap: Fix a leak of the IRQ during init failure
Browse files Browse the repository at this point in the history
In omap_rtc_probe error path, free_irq() was using NULL rather than the
driver data as the data pointer so free_irq() wouldn't have matched.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Cc: "George G. Davis" <gdavis@mvista.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: rtc-linux@googlegroups.com
Link: http://lkml.kernel.org/r/%3C1303005778.2889.2.camel%40phoenix%3E
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
  • Loading branch information
Axel Lin authored and Thomas Gleixner committed Apr 18, 2011
1 parent 1791f88 commit 2dd93c4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/rtc/rtc-omap.c
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@ static int __init omap_rtc_probe(struct platform_device *pdev)
return 0;

fail2:
free_irq(omap_rtc_timer, NULL);
free_irq(omap_rtc_timer, rtc);
fail1:
rtc_device_unregister(rtc);
fail0:
Expand Down

0 comments on commit 2dd93c4

Please sign in to comment.